[
https://issues.apache.org/jira/browse/HIVE-23324?focusedWorklogId=461682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461682
]
ASF GitHub Bot logged work on HIVE-23324:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/20 17:37
Start Date: 21/Jul/20 17:37
Worklog Time Spent: 10m
Work Description: adesh-rao commented on pull request #1275:
URL: https://github.com/apache/hive/pull/1275#issuecomment-662004212
@belugabehr
1) `clean` method does not return anything (`void`). I couldn't find a way
to create a `CompletionService` on `void` return type. This means that to use
CompletionService, `clean` method's definition need to be changed.
2) we don't care about which executor threads are getting completed when,
and also, all the related logging about directory/files deletion are being done
in `clean` method only.
Therefore,
`
for (int i = 0; i < 10; ++i) {
try {
String path = completionService.take().get();
System.out.println(path);
} catch (Exception ignore) {}
}`
the above code will be extra lines of code when we can just use `join()`
instead (I think that might have been the initial intention too).
So, the suggestion that you have provided, if necessary, we can take it up
in a separate jira (This will require similar changes in Initiator thread too).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 461682)
Time Spent: 2h 10m (was: 2h)
> Parallelise compaction directory cleaning process
> -------------------------------------------------
>
> Key: HIVE-23324
> URL: https://issues.apache.org/jira/browse/HIVE-23324
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Adesh Kumar Rao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Initiator processes the various compaction candidates in parallel, so we
> could follow a similar approach in Cleaner where we currently clean the
> directories sequentially.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
