[
https://issues.apache.org/jira/browse/HIVE-23324?focusedWorklogId=461938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461938
]
ASF GitHub Bot logged work on HIVE-23324:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/20 09:54
Start Date: 22/Jul/20 09:54
Worklog Time Spent: 10m
Work Description: adesh-rao commented on a change in pull request #1275:
URL: https://github.com/apache/hive/pull/1275#discussion_r458675680
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -149,17 +156,25 @@ public void run() {
String runAs = resolveUserToRunAs(tblNameOwners, t, p);
/* checkForCompaction includes many file metadata checks and may
be expensive.
* Therefore, using a thread pool here and running
checkForCompactions in parallel */
-
compactionList.add(CompletableFuture.runAsync(ThrowingRunnable.unchecked(() ->
- scheduleCompactionIfRequired(ci, t, p, runAs)),
compactionExecutor));
+ completionService.submit(() -> {
+ ThrowingRunnable.unchecked(() ->
scheduleCompactionIfRequired(ci, t, p, runAs));
+ return null;
+ });
+ count++;
} catch (Throwable t) {
LOG.error("Caught exception while trying to determine if we
should compact {}. " +
"Marking failed to avoid repeated failures, {}", ci, t);
ci.errorMessage = t.getMessage();
txnHandler.markFailed(ci);
}
}
- CompletableFuture.allOf(compactionList.toArray(new
CompletableFuture[0]))
- .join();
+ for(int i=0; i<count; i++) {
Review comment:
Earlier I missed the fact that we don't care in how and when are task
getting completed and using join is better in terms of readability and
usability too. So I have reverted this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 461938)
Time Spent: 5h 20m (was: 5h 10m)
> Parallelise compaction directory cleaning process
> -------------------------------------------------
>
> Key: HIVE-23324
> URL: https://issues.apache.org/jira/browse/HIVE-23324
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Adesh Kumar Rao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Initiator processes the various compaction candidates in parallel, so we
> could follow a similar approach in Cleaner where we currently clean the
> directories sequentially.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
