[
https://issues.apache.org/jira/browse/HIVE-23198?focusedWorklogId=462480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462480
]
ASF GitHub Bot logged work on HIVE-23198:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/20 10:13
Start Date: 23/Jul/20 10:13
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459347299
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP
side only, where the received request may
Review comment:
Proactive eviction requests are on a per DB basis:
https://github.com/apache/hive/blob/master/llap-common/src/protobuf/LlapDaemonProtocol.proto#L234-L238
This comment is just a heads-up of that fact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 462480)
Time Spent: 1h (was: 50m)
> Add matching logic between CacheTags and proactive eviction requests
> --------------------------------------------------------------------
>
> Key: HIVE-23198
> URL: https://issues.apache.org/jira/browse/HIVE-23198
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Implement ProactiveEviction$Request#isTagMatch so that LLAP can evict buffers
> based on their tags matching incoming eviction requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
