[
https://issues.apache.org/jira/browse/HIVE-23716?focusedWorklogId=463337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463337
]
ASF GitHub Bot logged work on HIVE-23716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/20 12:03
Start Date: 26/Jul/20 12:03
Worklog Time Spent: 10m
Work Description: maheshk114 commented on a change in pull request #1147:
URL: https://github.com/apache/hive/pull/1147#discussion_r460518799
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinWithFilterToAntiJoinRule.java
##########
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.optimizer.calcite.rules;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelOptUtil;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.core.JoinRelType;
+import org.apache.calcite.rel.core.Project;
+import org.apache.calcite.rel.type.RelDataTypeField;
+import org.apache.calcite.rex.RexInputRef;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.util.ImmutableBitSet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Planner rule that converts a join plus filter to anti join.
+ */
+public class HiveJoinWithFilterToAntiJoinRule extends RelOptRule {
+ protected static final Logger LOG =
LoggerFactory.getLogger(HiveJoinWithFilterToAntiJoinRule.class);
+ public static final HiveJoinWithFilterToAntiJoinRule INSTANCE = new
HiveJoinWithFilterToAntiJoinRule();
+
+ // HiveProject(fld=[$0])
+ // HiveFilter(condition=[IS NULL($1)])
+ // HiveJoin(condition=[=($0, $1)], joinType=[left], algorithm=[none],
cost=[not available])
+ //
+ // TO
+ //
+ // HiveProject(fld_tbl=[$0])
+ // HiveAntiJoin(condition=[=($0, $1)], joinType=[anti])
+ //
+ public HiveJoinWithFilterToAntiJoinRule() {
+ super(operand(Project.class, operand(Filter.class, operand(Join.class,
RelOptRule.any()))),
+ "HiveJoinWithFilterToAntiJoinRule:filter");
+ }
+
+ // is null filter over a left join.
+ public void onMatch(final RelOptRuleCall call) {
+ final Project project = call.rel(0);
+ final Filter filter = call.rel(1);
+ final Join join = call.rel(2);
+ perform(call, project, filter, join);
+ }
+
+ protected void perform(RelOptRuleCall call, Project project, Filter filter,
Join join) {
+ LOG.debug("Matched HiveAntiJoinRule");
+
+ if (join.getCondition().isAlwaysTrue()) {
+ return;
+ }
+
+ //We support conversion from left outer join only.
+ if (join.getJoinType() != JoinRelType.LEFT) {
+ return;
+ }
+
+ assert (filter != null);
+
+ List<RexNode> aboveFilters =
RelOptUtil.conjunctions(filter.getCondition());
+ boolean hasIsNull = false;
+
+ // Get all filter condition and check if any of them is a "is null" kind.
+ for (RexNode filterNode : aboveFilters) {
+ if (filterNode.getKind() == SqlKind.IS_NULL &&
+ isFilterFromRightSide(join, filterNode, join.getJoinType())) {
+ hasIsNull = true;
+ break;
+ }
+ }
+
+ // Is null should be on a key from right side of the join.
+ if (!hasIsNull) {
+ return;
+ }
+
+ // Build anti join with same left, right child and condition as original
left outer join.
+ Join anti = join.copy(join.getTraitSet(), join.getCondition(),
+ join.getLeft(), join.getRight(), JoinRelType.ANTI, false);
+
+ //TODO : Do we really need it
+ call.getPlanner().onCopy(join, anti);
+
+ RelNode newProject = getNewProjectNode(project, anti);
+ if (newProject != null) {
+ call.getPlanner().onCopy(project, newProject);
Review comment:
done
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinWithFilterToAntiJoinRule.java
##########
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.optimizer.calcite.rules;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelOptUtil;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.core.JoinRelType;
+import org.apache.calcite.rel.core.Project;
+import org.apache.calcite.rel.type.RelDataTypeField;
+import org.apache.calcite.rex.RexInputRef;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.util.ImmutableBitSet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Planner rule that converts a join plus filter to anti join.
+ */
+public class HiveJoinWithFilterToAntiJoinRule extends RelOptRule {
+ protected static final Logger LOG =
LoggerFactory.getLogger(HiveJoinWithFilterToAntiJoinRule.class);
+ public static final HiveJoinWithFilterToAntiJoinRule INSTANCE = new
HiveJoinWithFilterToAntiJoinRule();
+
+ // HiveProject(fld=[$0])
+ // HiveFilter(condition=[IS NULL($1)])
+ // HiveJoin(condition=[=($0, $1)], joinType=[left], algorithm=[none],
cost=[not available])
+ //
+ // TO
+ //
+ // HiveProject(fld_tbl=[$0])
+ // HiveAntiJoin(condition=[=($0, $1)], joinType=[anti])
+ //
+ public HiveJoinWithFilterToAntiJoinRule() {
+ super(operand(Project.class, operand(Filter.class, operand(Join.class,
RelOptRule.any()))),
+ "HiveJoinWithFilterToAntiJoinRule:filter");
+ }
+
+ // is null filter over a left join.
+ public void onMatch(final RelOptRuleCall call) {
+ final Project project = call.rel(0);
+ final Filter filter = call.rel(1);
+ final Join join = call.rel(2);
+ perform(call, project, filter, join);
+ }
+
+ protected void perform(RelOptRuleCall call, Project project, Filter filter,
Join join) {
+ LOG.debug("Matched HiveAntiJoinRule");
+
+ if (join.getCondition().isAlwaysTrue()) {
+ return;
+ }
+
+ //We support conversion from left outer join only.
+ if (join.getJoinType() != JoinRelType.LEFT) {
+ return;
+ }
+
+ assert (filter != null);
+
+ List<RexNode> aboveFilters =
RelOptUtil.conjunctions(filter.getCondition());
+ boolean hasIsNull = false;
+
+ // Get all filter condition and check if any of them is a "is null" kind.
+ for (RexNode filterNode : aboveFilters) {
+ if (filterNode.getKind() == SqlKind.IS_NULL &&
+ isFilterFromRightSide(join, filterNode, join.getJoinType())) {
+ hasIsNull = true;
+ break;
+ }
+ }
+
+ // Is null should be on a key from right side of the join.
+ if (!hasIsNull) {
+ return;
+ }
+
+ // Build anti join with same left, right child and condition as original
left outer join.
+ Join anti = join.copy(join.getTraitSet(), join.getCondition(),
+ join.getLeft(), join.getRight(), JoinRelType.ANTI, false);
+
+ //TODO : Do we really need it
+ call.getPlanner().onCopy(join, anti);
Review comment:
done
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinWithFilterToAntiJoinRule.java
##########
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.optimizer.calcite.rules;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelOptUtil;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.core.JoinRelType;
+import org.apache.calcite.rel.core.Project;
+import org.apache.calcite.rel.type.RelDataTypeField;
+import org.apache.calcite.rex.RexInputRef;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.util.ImmutableBitSet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Planner rule that converts a join plus filter to anti join.
+ */
+public class HiveJoinWithFilterToAntiJoinRule extends RelOptRule {
+ protected static final Logger LOG =
LoggerFactory.getLogger(HiveJoinWithFilterToAntiJoinRule.class);
+ public static final HiveJoinWithFilterToAntiJoinRule INSTANCE = new
HiveJoinWithFilterToAntiJoinRule();
+
+ // HiveProject(fld=[$0])
+ // HiveFilter(condition=[IS NULL($1)])
+ // HiveJoin(condition=[=($0, $1)], joinType=[left], algorithm=[none],
cost=[not available])
+ //
+ // TO
+ //
+ // HiveProject(fld_tbl=[$0])
+ // HiveAntiJoin(condition=[=($0, $1)], joinType=[anti])
+ //
+ public HiveJoinWithFilterToAntiJoinRule() {
+ super(operand(Project.class, operand(Filter.class, operand(Join.class,
RelOptRule.any()))),
+ "HiveJoinWithFilterToAntiJoinRule:filter");
+ }
+
+ // is null filter over a left join.
+ public void onMatch(final RelOptRuleCall call) {
+ final Project project = call.rel(0);
+ final Filter filter = call.rel(1);
+ final Join join = call.rel(2);
+ perform(call, project, filter, join);
+ }
+
+ protected void perform(RelOptRuleCall call, Project project, Filter filter,
Join join) {
+ LOG.debug("Matched HiveAntiJoinRule");
+
+ if (join.getCondition().isAlwaysTrue()) {
+ return;
+ }
+
+ //We support conversion from left outer join only.
+ if (join.getJoinType() != JoinRelType.LEFT) {
+ return;
+ }
+
+ assert (filter != null);
+
+ List<RexNode> aboveFilters =
RelOptUtil.conjunctions(filter.getCondition());
+ boolean hasIsNull = false;
+
+ // Get all filter condition and check if any of them is a "is null" kind.
+ for (RexNode filterNode : aboveFilters) {
+ if (filterNode.getKind() == SqlKind.IS_NULL &&
+ isFilterFromRightSide(join, filterNode, join.getJoinType())) {
+ hasIsNull = true;
+ break;
+ }
+ }
+
+ // Is null should be on a key from right side of the join.
+ if (!hasIsNull) {
+ return;
+ }
+
+ // Build anti join with same left, right child and condition as original
left outer join.
+ Join anti = join.copy(join.getTraitSet(), join.getCondition(),
+ join.getLeft(), join.getRight(), JoinRelType.ANTI, false);
+
+ //TODO : Do we really need it
+ call.getPlanner().onCopy(join, anti);
+
+ RelNode newProject = getNewProjectNode(project, anti);
+ if (newProject != null) {
+ call.getPlanner().onCopy(project, newProject);
+ call.transformTo(newProject);
+ }
+ }
+
+ protected RelNode getNewProjectNode(Project oldProject, Join newJoin) {
+ List<RelDataTypeField> newJoinFiledList =
newJoin.getRowType().getFieldList();
+ List<RexNode> newProjectExpr = new ArrayList<>();
+ for (RexNode field : oldProject.getProjects()) {
+ if (!(field instanceof RexInputRef)) {
+ return null;
+ }
+ int idx = ((RexInputRef)field).getIndex();
+ if (idx > newJoinFiledList.size()) {
+ LOG.debug(" Project filed " + ((RexInputRef) field).getName() +
+ " is from right side of join. Can not convert to anti join.");
+ return null;
+ }
+
+ final RexInputRef ref = newJoin.getCluster().getRexBuilder()
+ .makeInputRef(field.getType(), idx);
+ newProjectExpr.add(ref);
+ }
+ return oldProject.copy(oldProject.getTraitSet(), newJoin, newProjectExpr,
oldProject.getRowType());
+ }
+
+ private boolean isFilterFromRightSide(RelNode joinRel, RexNode filter,
JoinRelType joinType) {
+ List<RelDataTypeField> joinFields = joinRel.getRowType().getFieldList();
+ int nTotalFields = joinFields.size();
+
+ List<RelDataTypeField> leftFields =
(joinRel.getInputs().get(0)).getRowType().getFieldList();
+ int nFieldsLeft = leftFields.size();
+ List<RelDataTypeField> rightFields =
(joinRel.getInputs().get(1)).getRowType().getFieldList();
+ int nFieldsRight = rightFields.size();
+ assert nTotalFields == (!joinType.projectsRight() ? nFieldsLeft :
nFieldsLeft + nFieldsRight);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 463337)
Time Spent: 10h 50m (was: 10h 40m)
> Support Anti Join in Hive
> --------------------------
>
> Key: HIVE-23716
> URL: https://issues.apache.org/jira/browse/HIVE-23716
> Project: Hive
> Issue Type: Bug
> Reporter: mahesh kumar behera
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23716.01.patch
>
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> Currently hive does not support Anti join. The query for anti join is
> converted to left outer join and null filter on right side join key is added
> to get the desired result. This is causing
> # Extra computation — The left outer join projects the redundant columns
> from right side. Along with that, filtering is done to remove the redundant
> rows. This is can be avoided in case of anti join as anti join will project
> only the required columns and rows from the left side table.
> # Extra shuffle — In case of anti join the duplicate records moved to join
> node can be avoided from the child node. This can reduce significant amount
> of data movement if the number of distinct rows( join keys) is significant.
> # Extra Memory Usage - In case of map based anti join , hash set is
> sufficient as just the key is required to check if the records matches the
> join condition. In case of left join, we need the key and the non key columns
> also and thus a hash table will be required.
> For a query like
> {code:java}
> select wr_order_number FROM web_returns LEFT JOIN web_sales ON
> wr_order_number = ws_order_number WHERE ws_order_number IS NULL;{code}
> The number of distinct ws_order_number in web_sales table in a typical 10TB
> TPCDS set up is just 10% of total records. So when we convert this query to
> anti join, instead of 7 billion rows, only 600 million rows are moved to join
> node.
> In the current patch, just one conversion is done. The pattern of
> project->filter->left-join is converted to project->anti-join. This will take
> care of sub queries with “not exists” clause. The queries with “not exists”
> are converted first to filter + left-join and then its converted to anti
> join. The queries with “not in” are not handled in the current patch.
> From execution side, both merge join and map join with vectorized execution
> is supported for anti join.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
