[
https://issues.apache.org/jira/browse/HIVE-23723?focusedWorklogId=464459&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-464459
]
ASF GitHub Bot logged work on HIVE-23723:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/20 09:45
Start Date: 30/Jul/20 09:45
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #1323:
URL: https://github.com/apache/hive/pull/1323#discussion_r462852316
##########
File path: ql/src/test/results/clientpositive/llap/explainuser_1.q.out
##########
@@ -124,27 +124,25 @@ Stage-3
<-Reducer 2 [SIMPLE_EDGE] llap
File Output Operator [FS_7]
table:{"name:":"default.src_orc_merge_test_part_n1"}
- Select Operator [SEL_6] (rows=100 width=95)
+ Select Operator [SEL_4] (rows=100 width=178)
Output:["_col0","_col1"]
Limit [LIM_5] (rows=100 width=178)
Number of rows:100
- Select Operator [SEL_4] (rows=100 width=178)
- Output:["_col0","_col1"]
- <-Map 1 [CUSTOM_SIMPLE_EDGE] llap
- PARTITION_ONLY_SHUFFLE [RS_3]
- Limit [LIM_2] (rows=100 width=178)
- Number of rows:100
- Select Operator [SEL_1] (rows=500 width=178)
- Output:["_col0","_col1"]
- TableScan [TS_0] (rows=500 width=178)
-
default@src,src,Tbl:COMPLETE,Col:COMPLETE,Output:["key","value"]
+ <-Map 1 [CUSTOM_SIMPLE_EDGE] llap
+ PARTITION_ONLY_SHUFFLE [RS_3]
+ Limit [LIM_2] (rows=100 width=178)
Review comment:
Why couldn't be pushed through`[SEL_1]` ?
##########
File path: ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out
##########
@@ -108,7 +111,7 @@ limit 1
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src
#### A masked pattern was here ####
-0 val_0 0 val_0
+238 val_238 238 val_238
Review comment:
Does `-- SORT_QUERY_RESULTS` help avoid resultset change?
##########
File path: ql/src/test/results/clientpositive/llap/input14_limit.q.out
##########
@@ -75,19 +75,19 @@ STAGE PLANS:
Reducer 2
Execution mode: vectorized, llap
Reduce Operator Tree:
- Select Operator
- expressions: VALUE._col0 (type: string), VALUE._col1 (type:
string)
- outputColumnNames: _col0, _col1
- Statistics: Num rows: 500 Data size: 89000 Basic stats:
COMPLETE Column stats: COMPLETE
- Limit
- Number of rows: 20
- Statistics: Num rows: 20 Data size: 3560 Basic stats:
COMPLETE Column stats: COMPLETE
- Top N Key Operator
- sort order: +
- keys: _col0 (type: string)
- null sort order: a
+ Limit
Review comment:
It is worth investigating why we end up with a plan where the parent of
a `TNK` is a `Limit` but that can be a follow-up patch since it is out of scope
of this patch.
##########
File path: ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out
##########
@@ -1207,7 +1223,6 @@ limit 1 offset 1
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src
#### A masked pattern was here ####
-0 val_0 0 val_0
Review comment:
Result set disappeared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 464459)
Time Spent: 0.5h (was: 20m)
> Limit operator pushdown through LOJ
> -----------------------------------
>
> Key: HIVE-23723
> URL: https://issues.apache.org/jira/browse/HIVE-23723
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Limit operator (without an order by) can be pushed through SELECTS and LEFT
> OUTER JOINs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
