[
https://issues.apache.org/jira/browse/HIVE-23960?focusedWorklogId=465013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465013
]
ASF GitHub Bot logged work on HIVE-23960:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/20 12:51
Start Date: 31/Jul/20 12:51
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1343:
URL: https://github.com/apache/hive/pull/1343#discussion_r463591370
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -6993,11 +6993,16 @@ public GetPartitionsByNamesResult
get_partitions_by_names_req(GetPartitionsByNam
// request them separately.
for (Partition part: ret) {
String partName = Warehouse.makePartName(table.getPartitionKeys(),
part.getValues());
- List<ColumnStatistics> partColStatsList =
- getMS().getPartitionColumnStatistics(parsedCatName,
parsedDbName, tblName,
- Collections.singletonList(partName),
-
StatsSetupConst.getColumnsHavingStats(part.getParameters()),
- engine);
+ List<ColumnStatistics> partColStatsList = null;
+ List<String> colNames =
StatsSetupConst.getColumnsHavingStats(part.getParameters());
Review comment:
Might be a good idea to push this check inside the
getPartitionColumnStatistics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 465013)
Time Spent: 20m (was: 10m)
> Partition with no column statistics leads to unbalanced calls to
> openTransaction/commitTransaction error during get_partitions_by_names
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-23960
> URL: https://issues.apache.org/jira/browse/HIVE-23960
> Project: Hive
> Issue Type: Task
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23960.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:#172b4d}Creating a partition with data and adding another partition is
> leading to unbalanced calls to open/commit transaction during
> get_partitions_by_names call.{color}
> {color:#172b4d}Issue was discovered during REPL DUMP operation which uses
> this HMS call to get the metadata of partition. This error occurs when there
> is a partition with no column statistics.{color}
> {color:#172b4d}To reproduce:{color}
> {code:java}
> CREATE TABLE student_part_acid(name string, age int, gpa double) PARTITIONED
> BY (ds string) STORED AS orc;
> LOAD DATA INPATH ‘/user/hive/partDir/student_part_acid/ds=20110924’ INTO
> TABLE student_part_acid partition(ds=20110924);
> ALTER TABLE student_part_acid ADD PARTITION (ds=20110925);
> Now if we try to preform REPL DUMP it fails with this the error "Unbalanced
> calls to open/commit transaction" on the HS2 side.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
