[
https://issues.apache.org/jira/browse/HIVE-23951?focusedWorklogId=465946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465946
]
ASF GitHub Bot logged work on HIVE-23951:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/20 23:13
Start Date: 03/Aug/20 23:13
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464709177
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import java.io.Serializable;
+import java.util.List;
+
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.hadoop.hive.common.StringInternUtils;
+import org.apache.hadoop.hive.serde.serdeConstants;
+import org.apache.hadoop.hive.serde2.objectinspector.ConstantObjectInspector;
+import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector.Category;
+import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils;
+import org.apache.hadoop.hive.serde2.typeinfo.BaseCharTypeInfo;
+import org.apache.hadoop.hive.serde2.typeinfo.StructTypeInfo;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoUtils;
+
+/**
+ * A constant expression.
+ */
+public class ExprDynamicParamDesc extends ExprNodeDesc implements Serializable
{
+ private static final long serialVersionUID = 1L;
+ final protected transient static char[] hexArray =
"0123456789ABCDEF".toCharArray();
+
+ private int index;
+ private Object value;
+
+ public ExprDynamicParamDesc() {
+ }
+
+ public ExprDynamicParamDesc(TypeInfo typeInfo, int index, Object value) {
+ super(typeInfo);
+ this.index = index;
+ this.value = value;
+ }
+
+ public Object getValue() {
+ return value;
+ }
+
+ public int getIndex() {
+ return index;
+ }
+
+
+ @Override
+ public String toString() {
+ return "Dynamic Parameter " + " index: " + index;
Review comment:
"Dynamic Parameter" makes it clear that the expression in an explain
plan is dynamic expression. Just showing index will make it hard to read.
What is the benefit of making it more compact?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 465946)
Time Spent: 1h 20m (was: 1h 10m)
> Support parameterized queries in WHERE/HAVING clause
> ----------------------------------------------------
>
> Key: HIVE-23951
> URL: https://issues.apache.org/jira/browse/HIVE-23951
> Project: Hive
> Issue Type: Sub-task
> Components: Query Planning
> Reporter: Vineet Garg
> Assignee: Vineet Garg
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
