[
https://issues.apache.org/jira/browse/HIVE-23963?focusedWorklogId=466327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466327
]
ASF GitHub Bot logged work on HIVE-23963:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/20 16:57
Start Date: 04/Aug/20 16:57
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1357:
URL: https://github.com/apache/hive/pull/1357#discussion_r465194632
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelDistribution.java
##########
@@ -82,7 +83,14 @@ public RelDistribution apply(TargetMapping mapping) {
}
List<Integer> newKeys = new ArrayList<>(keys.size());
for (Integer key : keys) {
- newKeys.add(mapping.getTargetOpt(key));
+ // Instead of this inner for loop
newKeys.add(mapping.getTargetOpt(key)); should be called but not all the
Review comment:
nit. Can we add the mapping to a map and do the lookup, instead of
having a nested loop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 466327)
Time Spent: 20m (was: 10m)
> UnsupportedOperationException in queries 74 and 84 while applying
> HiveCardinalityPreservingJoinRule
> ---------------------------------------------------------------------------------------------------
>
> Key: HIVE-23963
> URL: https://issues.apache.org/jira/browse/HIVE-23963
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Stamatis Zampetakis
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Attachments: cbo_query74_stacktrace.txt, cbo_query84_stacktrace.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following TPC-DS queries:
> * cbo_query74.q
> * cbo_query84.q
> * query74.q
> * query84.q
> fail on the metastore with the partitioned TPC-DS 30TB dataset.
> The stacktraces for cbo_query74 and cbo_query84 show that the problem
> originates while applying HiveCardinalityPreservingJoinRule.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
