[
https://issues.apache.org/jira/browse/HIVE-23890?focusedWorklogId=467831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467831
]
ASF GitHub Bot logged work on HIVE-23890:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/20 12:25
Start Date: 07/Aug/20 12:25
Worklog Time Spent: 10m
Work Description: bmaidics commented on a change in pull request #1330:
URL: https://github.com/apache/hive/pull/1330#discussion_r467007215
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{
4: optional string errorMessage,
}
+struct GetFileListRequest {
+ 1: optional string catName,
+ 2: optional string dbName,
+ 3: optional string tableName,
+ 4: optional list<string> partVals,
+ 6: optional string validWriteIdList
+}
+
+struct GetFileListResponse {
+ 1: optional list<binary> fileListData,
+ 2: optional i32 fbVersionNumber
Review comment:
I agree. Here I wanted to express, that the version represents the
fields in the flatbuffer file. In the first version, we'd like to store
relative_path, length, last_modification_time, and file_format, but in future
versions, we might want to add more fields. But you're right, this naming is
confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467831)
Time Spent: 1h 10m (was: 1h)
> Create HMS endpoint for querying file lists using FlatBuffers as serialization
> ------------------------------------------------------------------------------
>
> Key: HIVE-23890
> URL: https://issues.apache.org/jira/browse/HIVE-23890
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Barnabas Maidics
> Assignee: Barnabas Maidics
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> New thrift objects would be:
> {code:java}
> struct GetFileListRequest {
> 1: optional string catName,
> 2: required string dbName,
> 3: required string tableName,
> 4: required list<string> partVals,
> 6: optional string validWriteIdList
> }
> struct GetFileListResponse {
> 1: required binary fileListData
> }
> {code}
> Where GetFileListResponse contains a binary field, which would be a
> FlatBuffer object
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
