[
https://issues.apache.org/jira/browse/HIVE-23993?focusedWorklogId=468994&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468994
]
ASF GitHub Bot logged work on HIVE-23993:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/20 03:00
Start Date: 11/Aug/20 03:00
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1367:
URL: https://github.com/apache/hive/pull/1367#discussion_r468298769
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcrossInstances.java
##########
@@ -1639,12 +1655,68 @@ public void
testFailureUnsupportedAuthorizerReplication() throws Throwable {
.run("insert into table1 values (2)");
try {
primary.dump(primaryDbName, clause);
+ Assert.fail();
} catch (SemanticException e) {
assertEquals("Invalid config error : Authorizer sentry not supported for
replication " +
"for ranger service.", e.getMessage());
assertEquals(ErrorMsg.REPL_INVALID_CONFIG_FOR_SERVICE.getErrorCode(),
ErrorMsg.getErrorMsg(e.getMessage()).getErrorCode());
}
+ //This is now non recoverable error
+ try {
+ primary.dump(primaryDbName, clause);
+ Assert.fail();
+ } catch (Exception e) {
+
assertEquals(ErrorMsg.REPL_FAILED_WITH_NON_RECOVERABLE_ERROR.getErrorCode(),
+ ErrorMsg.getErrorMsg(e.getMessage()).getErrorCode());
+ }
+ //Delete non recoverable marker to fix this
Review comment:
I have added a check for marker file. But that will just test the fs
delete call.
Also load will fail as the dump doesn't exist, not because of non
recoverable error. Those kind of tests are already present and not part of this
feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468994)
Time Spent: 0.5h (was: 20m)
> Handle irrecoverable errors
> ---------------------------
>
> Key: HIVE-23993
> URL: https://issues.apache.org/jira/browse/HIVE-23993
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23993.01.patch, HIVE-23993.02.patch, Retry Logic
> for Replication.pdf
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
