[
https://issues.apache.org/jira/browse/HIVE-12679?focusedWorklogId=473338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473338
]
ASF GitHub Bot logged work on HIVE-12679:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 16:36
Start Date: 21/Aug/20 16:36
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-678382353
I would like to bring up the comment from @thejasmn which sounds valid to me.
"Note that SessionHiveMetaStoreClient implements logic for temp tables, as
they have a lifetime of a session. I am wondering if this config should
determine which IMetaStoreClient impl is used by SessionHiveMetaStoreClient,
instead of replacing SessionHiveMetaStoreClient itself.
Some changes to SessionHiveMetaStoreClient would be needed as well for that
approach, for it to accept configured IMetaStoreClient."
Would you pls address this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 473338)
Time Spent: 40m (was: 0.5h)
> Allow users to be able to specify an implementation of IMetaStoreClient via
> HiveConf
> ------------------------------------------------------------------------------------
>
> Key: HIVE-12679
> URL: https://issues.apache.org/jira/browse/HIVE-12679
> Project: Hive
> Issue Type: Improvement
> Components: Configuration, Metastore, Query Planning
> Reporter: Austin Lee
> Priority: Minor
> Labels: metastore, pull-request-available
> Attachments: HIVE-12679.1.patch, HIVE-12679.2.patch,
> HIVE-12679.branch-1.2.patch, HIVE-12679.branch-2.3.patch, HIVE-12679.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Hi,
> I would like to propose a change that would make it possible for users to
> choose an implementation of IMetaStoreClient via HiveConf, i.e.
> hive-site.xml. Currently, in Hive the choice is hard coded to be
> SessionHiveMetaStoreClient in org.apache.hadoop.hive.ql.metadata.Hive. There
> is no other direct reference to SessionHiveMetaStoreClient other than the
> hard coded class name in Hive.java and the QL component operates only on the
> IMetaStoreClient interface so the change would be minimal and it would be
> quite similar to how an implementation of RawStore is specified and loaded in
> hive-metastore. One use case this change would serve would be one where a
> user wishes to use an implementation of this interface without the dependency
> on the Thrift server.
>
> Thank you,
> Austin
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
