[
https://issues.apache.org/jira/browse/HIVE-24120?focusedWorklogId=479105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479105
]
ASF GitHub Bot logged work on HIVE-24120:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/20 13:35
Start Date: 04/Sep/20 13:35
Worklog Time Spent: 10m
Work Description: gatorblue opened a new pull request #1470:
URL: https://github.com/apache/hive/pull/1470
This PR implements the design outlined in this doc:
https://docs.google.com/document/d/1lR2IDiqjMiG1zb7o_4sEa6wULzH1CvtRodsghCtxYWY/edit#heading=h.imzjzzvayyi1
Quoting from the design doc:
**Goals**
Introduce a way to load a custom jar in metastore which can override
database specific DatabaseProduct which provides the database specific SQL code
execution in Hive Metastore.
**Non-goals**
We do not want to evolve metastore into a Datanucleus (ORM) like software
which transparently handles all the different nuances of supporting multiple
database types. The pluggable custom instance of the DatabaseProduct must be
ANSI SQL compliant since the MetastoreDirectSQL and SqlGenerator assumes that.
We would like to keep the changes to MetastoreDirectSQL at minimum and assume
that all the supported databases are ANSI SQL compliant.
Upgrade and performance testing of custom implementations.
Schematool to be able to load this custom jar to execute schema
initialization and upgrade scripts. This is not currently in scope of this
document.
**About this PR**
As per the design, DatabaseProduct has been refactored as a class.
It's a singleton class, which gets instantiated the first time method
determineDatabaseProduct is invoked.
Existing SQL logic that was scattered around other classes has been moved to
methods in this class. This makes it
possible for an external plugin to override the existing SQL logic.
@vihangk1 @thejasmn @nrg4878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 479105)
Remaining Estimate: 0h
Time Spent: 10m
> Plugin for external DatabaseProduct in standalone HMS
> -----------------------------------------------------
>
> Key: HIVE-24120
> URL: https://issues.apache.org/jira/browse/HIVE-24120
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 3.1.1
> Reporter: Gustavo Arocena
> Assignee: Gustavo Arocena
> Priority: Minor
> Fix For: 4.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add a pluggable way to support ANSI compliant databases as backends for
> standalone HMS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)