[ 
https://issues.apache.org/jira/browse/HIVE-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934555#comment-14934555
 ] 

Pengcheng Xiong commented on HIVE-11960:
----------------------------------------

[~sershe], the patch generally looks good. I have 2 comments (1) {code} (LPAREN 
KW_VALUES) => fromSource0{code} is redundant and can be removed? (2) Could you 
add more test cases involving more braces, e.g., {code}select (u.uid) from 
(((user u join user u1 on u.uid=u1.uid)));{code}? Thanks.

> braces in join conditions are not supported
> -------------------------------------------
>
>                 Key: HIVE-11960
>                 URL: https://issues.apache.org/jira/browse/HIVE-11960
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-11960.01.patch, HIVE-11960.patch
>
>
> These should be supported; they are ANSI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to