[
https://issues.apache.org/jira/browse/HIVE-23618?focusedWorklogId=490830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-490830
]
ASF GitHub Bot logged work on HIVE-23618:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/20 13:17
Start Date: 25/Sep/20 13:17
Worklog Time Spent: 10m
Work Description: sankarh commented on a change in pull request #1237:
URL: https://github.com/apache/hive/pull/1237#discussion_r494034909
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -703,6 +709,49 @@ public void
onAddNotNullConstraint(AddNotNullConstraintEvent addNotNullConstrain
}
}
+ /***
+ * @param addDefaultConstraintEvent add default constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddDefaultConstraint(AddDefaultConstraintEvent
addDefaultConstraintEvent) throws MetaException {
+ List<SQLDefaultConstraint> cols =
addDefaultConstraintEvent.getDefaultConstraintCols();
+ if (cols.size() > 0) {
+ AddDefaultConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddDefaultConstraintMessage(addDefaultConstraintEvent.getDefaultConstraintCols());
Review comment:
I meant, use cols instead of
addDefaultConstraintEvent.getDefaultConstraintCols().
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -703,6 +709,49 @@ public void
onAddNotNullConstraint(AddNotNullConstraintEvent addNotNullConstrain
}
}
+ /***
+ * @param addDefaultConstraintEvent add default constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddDefaultConstraint(AddDefaultConstraintEvent
addDefaultConstraintEvent) throws MetaException {
+ List<SQLDefaultConstraint> cols =
addDefaultConstraintEvent.getDefaultConstraintCols();
+ if (cols.size() > 0) {
+ AddDefaultConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddDefaultConstraintMessage(addDefaultConstraintEvent.getDefaultConstraintCols());
+ NotificationEvent event =
+ new NotificationEvent(0, now(),
EventType.ADD_DEFAULTCONSTRAINT.toString(),
+ msgEncoder.getSerializer().serialize(msg)
+ );
+ event.setCatName(cols.get(0).isSetCatName() ? cols.get(0).getCatName() :
DEFAULT_CATALOG_NAME);
+ event.setDbName(cols.get(0).getTable_db());
+ event.setTableName(cols.get(0).getTable_name());
+ process(event, addDefaultConstraintEvent);
+ }
+ }
+
+ /***
+ * @param addCheckConstraintEvent add check constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddCheckConstraint(AddCheckConstraintEvent
addCheckConstraintEvent) throws MetaException {
+ LOG.info("Inside DBNotification listener for check constraint.");
+ List<SQLCheckConstraint> cols =
addCheckConstraintEvent.getCheckConstraintCols();
+ if (cols.size() > 0) {
+ AddCheckConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddCheckConstraintMessage(addCheckConstraintEvent.getCheckConstraintCols());
Review comment:
I meant, use cols instead of
addDefaultConstraintEvent.getDefaultConstraintCols().
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -703,6 +709,49 @@ public void
onAddNotNullConstraint(AddNotNullConstraintEvent addNotNullConstrain
}
}
+ /***
+ * @param addDefaultConstraintEvent add default constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddDefaultConstraint(AddDefaultConstraintEvent
addDefaultConstraintEvent) throws MetaException {
+ List<SQLDefaultConstraint> cols =
addDefaultConstraintEvent.getDefaultConstraintCols();
+ if (cols.size() > 0) {
+ AddDefaultConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddDefaultConstraintMessage(addDefaultConstraintEvent.getDefaultConstraintCols());
+ NotificationEvent event =
+ new NotificationEvent(0, now(),
EventType.ADD_DEFAULTCONSTRAINT.toString(),
+ msgEncoder.getSerializer().serialize(msg)
+ );
+ event.setCatName(cols.get(0).isSetCatName() ? cols.get(0).getCatName() :
DEFAULT_CATALOG_NAME);
+ event.setDbName(cols.get(0).getTable_db());
+ event.setTableName(cols.get(0).getTable_name());
+ process(event, addDefaultConstraintEvent);
+ }
+ }
+
+ /***
+ * @param addCheckConstraintEvent add check constraint event
+ * @throws MetaException
+ */
+ @Override
+ public void onAddCheckConstraint(AddCheckConstraintEvent
addCheckConstraintEvent) throws MetaException {
+ LOG.info("Inside DBNotification listener for check constraint.");
+ List<SQLCheckConstraint> cols =
addCheckConstraintEvent.getCheckConstraintCols();
+ if (cols.size() > 0) {
+ AddCheckConstraintMessage msg = MessageBuilder.getInstance()
+
.buildAddCheckConstraintMessage(addCheckConstraintEvent.getCheckConstraintCols());
Review comment:
I meant, use cols instead of
addCheckConstraintEvent.getCheckConstraintCols().
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -3236,13 +3236,29 @@ public void testConstraints() throws IOException {
List<SQLNotNullConstraint> nns =
metaStoreClientMirror.getNotNullConstraints(new
NotNullConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl6"));
assertEquals(nns.size(), 1);
nnName = nns.get(0).getNn_name();
- List<SQLCheckConstraint> cks =
metaStoreClientMirror.getCheckConstraints(new
CheckConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl9"));
+ List<SQLCheckConstraint> cks =
metaStoreClientMirror.getCheckConstraints(new
CheckConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName, "tbl9"));
assertEquals(cks.size(), 2);
ckName1 = cks.get(0).getDc_name();
ckName2 = cks.get(1).getDc_name();
- List<SQLDefaultConstraint> dks =
metaStoreClientMirror.getDefaultConstraints(new
DefaultConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl10"));
+ List<SQLDefaultConstraint> dks =
metaStoreClientMirror.getDefaultConstraints(new
DefaultConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName, "tbl10"));
assertEquals(dks.size(), 1);
- dkName = dks.get(0).getDc_name();
+ dkName1 = dks.get(0).getDc_name();
+ } catch (TException te) {
+ assertNull(te);
+ }
+
+ String dkName2 = "custom_dk_name";
+ String ckName3 = "customer_ck_name";
+ run("ALTER TABLE " + dbName+ ".tbl10 CHANGE COLUMN a a string CONSTRAINT "
+ ckName3 + " CHECK (a like 'a%')", driver);
Review comment:
nit: Add space before "+" in both lines.
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -3265,13 +3283,15 @@ public void testConstraints() throws IOException {
assertTrue(fks.isEmpty());
List<SQLNotNullConstraint> nns =
metaStoreClientMirror.getNotNullConstraints(new
NotNullConstraintsRequest(DEFAULT_CATALOG_NAME, replDbName , "tbl6"));
Review comment:
nit: Remove space before ","
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 490830)
Time Spent: 2h 50m (was: 2h 40m)
> Add notification events for default/check constraints and enable replication.
> -----------------------------------------------------------------------------
>
> Key: HIVE-23618
> URL: https://issues.apache.org/jira/browse/HIVE-23618
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 4.0.0
> Reporter: Adesh Kumar Rao
> Assignee: Adesh Kumar Rao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> This should follow similar approach of notNull/Unique constraints. This will
> also include event replication for these constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
