[ 
https://issues.apache.org/jira/browse/HIVE-24227?focusedWorklogId=495284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495284
 ]

ASF GitHub Bot logged work on HIVE-24227:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Oct/20 11:50
            Start Date: 05/Oct/20 11:50
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #1550:
URL: https://github.com/apache/hive/pull/1550#discussion_r499540414



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
##########
@@ -280,6 +299,49 @@ public static PathFilter getBootstrapDirectoryFilter(final 
FileSystem fs) {
     };
   }
 
+  public static Path getMetricPath(MessageHandler.Context context, HiveConf 
hiveConf) throws Exception{
+    DumpType dumpType;
+    Path metricPath = null;
+    String dumpMetaFile = DumpMetaData.getDmdFileName();
+    FileSystem fs = null;
+    if(context.dmd != null) {
+      dumpType = context.dmd.getDumpType();
+      fs = context.dmd.getDumpFilePath().getFileSystem(hiveConf);
+      metricPath = context.dmd.getDumpFilePath().getParent();
+    }
+    else {
+      dumpType = null;
+      if(context.location != null){
+        metricPath = (new Path(context.location)).getParent();
+        fs = (new Path(context.location)).getFileSystem(hiveConf);
+      }
+    }
+    //traverse to hiveDumpRoot required by metric-collector
+    while (metricPath != null && fs != null && dumpType != DumpType.BOOTSTRAP 
&& dumpType != DumpType.INCREMENTAL) {

Review comment:
       this may be error prone. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 495284)
    Time Spent: 2h  (was: 1h 50m)

> sys.replication_metrics table shows incorrect status for failed policies
> ------------------------------------------------------------------------
>
>                 Key: HIVE-24227
>                 URL: https://issues.apache.org/jira/browse/HIVE-24227
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Arko Sharma
>            Assignee: Arko Sharma
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to