[
https://issues.apache.org/jira/browse/HIVE-23695?focusedWorklogId=501564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501564
]
ASF GitHub Bot logged work on HIVE-23695:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/20 14:10
Start Date: 16/Oct/20 14:10
Worklog Time Spent: 10m
Work Description: ashish-kumar-sharma commented on a change in pull
request #1527:
URL: https://github.com/apache/hive/pull/1527#discussion_r506468233
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/TableCacheObjects.java
##########
@@ -3,59 +3,21 @@
import org.apache.hadoop.hive.metastore.api.AggrStats;
import org.apache.hadoop.hive.metastore.api.ColumnStatistics;
import org.apache.hadoop.hive.metastore.api.Partition;
-import org.apache.hadoop.hive.metastore.api.SQLForeignKey;
-import org.apache.hadoop.hive.metastore.api.SQLNotNullConstraint;
-import org.apache.hadoop.hive.metastore.api.SQLPrimaryKey;
-import org.apache.hadoop.hive.metastore.api.SQLUniqueConstraint;
+import org.apache.hadoop.hive.metastore.api.SQLAllTableConstraints;
import java.util.List;
/*
* Holder class for table objects like partitions, statistics, constraints etc.
*/
public class TableCacheObjects {
- private List<SQLPrimaryKey> primaryKeys;
- private List<SQLForeignKey> foreignKeys;
- private List<SQLNotNullConstraint> notNullConstraints;
- private List<SQLUniqueConstraint> uniqueConstraints;
+ private SQLAllTableConstraints tableConstraints;
Review comment:
Here tableConstraints is just a place holder to keep all constraint at
one place. In cache read and write flow each constraint is treated
independently. Maintained a fail safe flow by falling back to rawstore in case
of dirty read, wrong values and partial info present in cached store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 501564)
Time Spent: 1h (was: 50m)
> [CachedStore] Add check/default constraints in CachedStore
> ----------------------------------------------------------
>
> Key: HIVE-23695
> URL: https://issues.apache.org/jira/browse/HIVE-23695
> Project: Hive
> Issue Type: Sub-task
> Components: Standalone Metastore
> Reporter: Adesh Kumar Rao
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is blocked by HIVE-23618 (notification events are not generated for
> default/unique constraints, hence created a separate sub-task from
> HIVE-22015).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
