[
https://issues.apache.org/jira/browse/HIVE-24311?focusedWorklogId=504451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504451
]
ASF GitHub Bot logged work on HIVE-24311:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/20 11:06
Start Date: 24/Oct/20 11:06
Worklog Time Spent: 10m
Work Description: tkanng commented on pull request #1609:
URL: https://github.com/apache/hive/pull/1609#issuecomment-715899122
Failed Unit tests are not related with this patch. Anybody help to review
the code? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504451)
Time Spent: 20m (was: 10m)
> Rowcontainer should reset readBlocks when we clear rows to prevent OOM.
> -----------------------------------------------------------------------
>
> Key: HIVE-24311
> URL: https://issues.apache.org/jira/browse/HIVE-24311
> Project: Hive
> Issue Type: Bug
> Affects Versions: All Versions
> Reporter: Qiang.Kang
> Assignee: Qiang.Kang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hi, We found that `Rowcontainer.clearRows()` only reset some index, such as:
> `addCursor`, `itrCursor`, etc, without resetting read blocks.
> As we all know, `currentReadBlock` and `currentWriteBlock` is the main memory
> usage of a `Rowcontainer` and might be very large, depending on the data
> pattern.
> `currentReadBlock` and `currentWriteBlock` won't be the same object after
> rowcontainer flushed data to disk.
> Resetting `currentReadBlock` and `currentWriteBlock` while clearing rows will
> prevent OOM.
>
> Therefore, I submit a patch to reset read blocks for `Rowcontainer`, just
> like `PTFRowcontainer` does.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
