[
https://issues.apache.org/jira/browse/HIVE-24217?focusedWorklogId=504776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504776
]
ASF GitHub Bot logged work on HIVE-24217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/20 15:41
Start Date: 26/Oct/20 15:41
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #1542:
URL: https://github.com/apache/hive/pull/1542#discussion_r512060986
##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -1659,13 +1665,70 @@ public Integer
visitExpr_func(HplsqlParser.Expr_funcContext ctx) {
}
return 0;
}
-
+
+ /**
+ * User-defined function in a SQL query
+ */
+ public void execSql(String name, HplsqlParser.Expr_func_paramsContext ctx) {
+ if (execUserSql(ctx, name)) {
+ return;
+ }
+ StringBuilder sql = new StringBuilder();
+ sql.append(name);
+ sql.append("(");
+ if (ctx != null) {
+ int cnt = ctx.func_param().size();
+ for (int i = 0; i < cnt; i++) {
+ sql.append(evalPop(ctx.func_param(i).expr()));
+ if (i + 1 < cnt) {
+ sql.append(", ");
+ }
+ }
+ }
+ sql.append(")");
+ exec.stackPush(sql);
+ }
+
+ /**
+ * Execute a HPL/SQL user-defined function in a query
+ */
+ private boolean execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String
name) {
+ if (!function.exists(name.toUpperCase())) {
+ return false;
+ }
+ StringBuilder sql = new StringBuilder();
+ sql.append("hplsql('");
Review comment:
I didn't check since this is not new code, and fixing every issue in the
existing code was not the scope of this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 504776)
Time Spent: 4h 10m (was: 4h)
> HMS storage backend for HPL/SQL stored procedures
> -------------------------------------------------
>
> Key: HIVE-24217
> URL: https://issues.apache.org/jira/browse/HIVE-24217
> Project: Hive
> Issue Type: Bug
> Components: Hive, hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Attachments: HPL_SQL storedproc HMS storage.pdf
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> HPL/SQL procedures are currently stored in text files. The goal of this Jira
> is to implement a Metastore backend for storing and loading these procedures.
> This is an incremental step towards having fully capable stored procedures in
> Hive.
>
> See the attached design for more information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
