[
https://issues.apache.org/jira/browse/HIVE-24370?focusedWorklogId=511034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511034
]
ASF GitHub Bot logged work on HIVE-24370:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/20 20:42
Start Date: 12/Nov/20 20:42
Worklog Time Spent: 10m
Work Description: vnhive commented on a change in pull request #1664:
URL: https://github.com/apache/hive/pull/1664#discussion_r522413583
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -4664,6 +4664,58 @@ public void dropStoredProcedure(StoredProcedureRequest
request) throws MetaExcep
return client.get_all_stored_procedures(request);
}
+ /**
+ * Builder for the GetProjectionsSpec. This is a projection specification
for partitions returned from the HMS.
+ */
+ public static class GetPartitionProjectionsSpecBuilder {
Review comment:
@vineetgarg02
Thanks a lot for taking time to review the changes and comment on them.
The builder classes follow the builder pattern who's definition generally
calls for the presence of the build() method. I think creating a separate
interface with just the build() method that these classes implement carries a
slight risk of making them superfluous. I humbly ask you to reconsider this.
I agree that it makes sense to move the builder implementations to a
separate file and ease the burden on the large HiveMetaStoreClient file. But I
think the change should not be done as part of this JIRA. Do you think I can
create a separate JIRA for this and do it there ?
@vihangk1
Thank you very much for taking the time to review the changes and comment on
them.
I agree that we should look at creating builder methods for GetTableRequest
and GetPartitionRequest. But I am inclined to push the request builders out of
this JIRA. Do you think it would be OK to retain the projection specification
builders in this JIRA, create a separate JIRA for the Request builder and
handle that once I am done with the parent issue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 511034)
Time Spent: 1h 10m (was: 1h)
> Make the GetPartitionsProjectionSpec generic and add builder methods for
> tables and partitions in HiveMetaStoreClient
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-24370
> URL: https://issues.apache.org/jira/browse/HIVE-24370
> Project: Hive
> Issue Type: Task
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> HIVE-20306 defines a projection struct called GetPartitionsProjectionSpec
> While the name has Partition in its name, this is a fairly generic struct
> with nothing specific to partitions. This should be renamed to a more generic
> name (GetProjectionSpec ?) and builder methods of this class for tables and
> partitions must be added to HiveMetaStoreClient.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
