[
https://issues.apache.org/jira/browse/HIVE-24341?focusedWorklogId=511323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511323
]
ASF GitHub Bot logged work on HIVE-24341:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/20 12:03
Start Date: 13/Nov/20 12:03
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #1665:
URL: https://github.com/apache/hive/pull/1665#discussion_r522907947
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -151,8 +151,10 @@ private LlapIoImpl(Configuration conf) throws IOException {
LowLevelCachePolicy
realCachePolicy =
useLrfu ? new LowLevelLrfuCachePolicy(minAllocSize, totalMemorySize,
conf) : new LowLevelFifoCachePolicy();
- // TODO: if realCachePolicy is not something that supports proactive
caching
- // turn the feature off (LLAP_IO_PROACTIVE_EVICTION_ENABLED) and log it
+ if (!(realCachePolicy instanceof ProactiveEvictingCachePolicy.Impl)) {
Review comment:
It would be very cumbersome to check this on HS2 side due to potentially
different config files being used for HS2 and LLAP side. Also these services
might get restarted independently from each other with different config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 511323)
Time Spent: 1.5h (was: 1h 20m)
> Sweep phase for proactive cache eviction
> ----------------------------------------
>
> Key: HIVE-24341
> URL: https://issues.apache.org/jira/browse/HIVE-24341
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
