[
https://issues.apache.org/jira/browse/HIVE-22087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236272#comment-17236272
]
Naveen Gangam commented on HIVE-22087:
--------------------------------------
[~kgyrtkirk] Its been a while so my details are a little fuzzy but it was
certainly not my intention to remove a pre-event notification when a user
accesses the DB.
But aren't get get_*_core methods meant to be internal only and not meant to
fire notifications. I added a new thrift call
get_database_req(GetDatabaseRequest) which has the firePreEvent() after it
calls the get_database_core().
So my thinking might have been to fire events in thrift methods but they all
use get_database_core internally that doesn't do any auditing or events and HMS
code can internally use get_database_core() without duplicate events in case of
user calls, or without firing events say when a get_table_core() (just an
example) has a need to fetch the table's database and can use
get_database_core() without firing an event.
So it might have been intentional. Is there an issue? Thanks
> HMS Translation: Translate getDatabase() API to alter warehouse location
> ------------------------------------------------------------------------
>
> Key: HIVE-22087
> URL: https://issues.apache.org/jira/browse/HIVE-22087
> Project: Hive
> Issue Type: Sub-task
> Reporter: Naveen Gangam
> Assignee: Naveen Gangam
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22087.1.patch, HIVE-22087.2.patch,
> HIVE-22087.3.patch, HIVE-22087.5.patch, HIVE-22087.6.patch, HIVE-22087.7.patch
>
>
> It makes sense to translate getDatabase() calls as well, to alter the
> location for the Database based on whether or not the processor has
> capabilities to write to the managed warehouse directory. Every DB has 2
> locations, one external and the other in the managed warehouse directory. If
> the processor has any AcidWrite capability, then the location remains
> unchanged for the database.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
