[
https://issues.apache.org/jira/browse/HIVE-24397?focusedWorklogId=518762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518762
]
ASF GitHub Bot logged work on HIVE-24397:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/20 04:23
Start Date: 02/Dec/20 04:23
Worklog Time Spent: 10m
Work Description: nrg4878 commented on a change in pull request #1681:
URL: https://github.com/apache/hive/pull/1681#discussion_r533887656
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -1912,19 +1972,19 @@ private Table convertToTable(MTable mtbl) throws
MetaException {
// for backwards compatibility with old metastore persistence
if (mtbl.getViewOriginalText() != null) {
tableType = TableType.VIRTUAL_VIEW.toString();
- } else if (Boolean.parseBoolean(mtbl.getParameters().get("EXTERNAL"))) {
+ } else if (mtbl.getParameters() != null &&
Boolean.parseBoolean(mtbl.getParameters().get("EXTERNAL"))) {
tableType = TableType.EXTERNAL_TABLE.toString();
} else {
tableType = TableType.MANAGED_TABLE.toString();
}
}
Map<String, String> parameters = convertMap(mtbl.getParameters());
boolean isAcidTable = TxnUtils.isAcidTable(parameters);
- final Table t = new Table(mtbl.getTableName(),
mtbl.getDatabase().getName(), mtbl
- .getOwner(), mtbl.getCreateTime(), mtbl.getLastAccessTime(), mtbl
- .getRetention(), convertToStorageDescriptor(mtbl.getSd(), false,
isAcidTable),
- convertToFieldSchemas(mtbl.getPartitionKeys()), parameters,
- mtbl.getViewOriginalText(), mtbl.getViewExpandedText(), tableType);
+ final Table t = new Table(mtbl.getTableName(), mtbl.getDatabase() != null
? mtbl.getDatabase().getName() : null,
+ mtbl.getOwner(), mtbl.getCreateTime(), mtbl.getLastAccessTime(),
mtbl.getRetention(),
Review comment:
nit: remove additional spacing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 518762)
Time Spent: 1h 40m (was: 1.5h)
> Add the projection specification to the table request object and add
> placeholders in ObjectStore.java
> -----------------------------------------------------------------------------------------------------
>
> Key: HIVE-24397
> URL: https://issues.apache.org/jira/browse/HIVE-24397
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
