[
https://issues.apache.org/jira/browse/HIVE-24460?focusedWorklogId=519034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-519034
]
ASF GitHub Bot logged work on HIVE-24460:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/20 14:22
Start Date: 02/Dec/20 14:22
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1725:
URL: https://github.com/apache/hive/pull/1725#discussion_r534203356
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -1217,7 +1251,7 @@ private void addNotificationLog(NotificationEvent event,
ListenerEvent listenerE
params.add(catName);
}
- s = "insert into \"NOTIFICATION_LOG\" (" + columns + ") VALUES (" +
insertVal + ")";
+ String s = "insert into \"NOTIFICATION_LOG\" (" + columns + ") VALUES ("
+ insertVal + ")";
Review comment:
@miklosgergely Yes, for sure. And I can take a look at that in a future
refactoring, but this request is out of scope for this change which only
affects the generation of the "Next Event ID." Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 519034)
Time Spent: 0.5h (was: 20m)
> Refactor Get Next Event ID for DbNotificationListener
> -----------------------------------------------------
>
> Key: HIVE-24460
> URL: https://issues.apache.org/jira/browse/HIVE-24460
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Refactor event ID generation to match notification log ID generation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
