[
https://issues.apache.org/jira/browse/HIVE-23410?focusedWorklogId=521743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521743
]
ASF GitHub Bot logged work on HIVE-23410:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/20 15:31
Start Date: 08/Dec/20 15:31
Worklog Time Spent: 10m
Work Description: kuczoram commented on a change in pull request #1660:
URL: https://github.com/apache/hive/pull/1660#discussion_r538496432
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
##########
@@ -251,7 +271,7 @@ public void closeWriters(boolean abort) throws
HiveException {
}
}
- private void commit(FileSystem fs, List<Path> commitPaths) throws
HiveException {
+ private void commit(FileSystem fs, List<Path> commitPaths, List<Path>
deleteDeltas) throws HiveException {
Review comment:
I know, but I don't really know a better solution, only if we change the
internal structures in FileSinkOperator. Like using Lists instead of arrays.
But this could have unexpected side effects. I am open to try it but I would do
it under a separate Jira. I create one about investigating this refactoring.
https://issues.apache.org/jira/browse/HIVE-24505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 521743)
Time Spent: 2h 40m (was: 2.5h)
> ACID: Improve the delete and update operations to avoid the move step
> ---------------------------------------------------------------------
>
> Key: HIVE-23410
> URL: https://issues.apache.org/jira/browse/HIVE-23410
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Marta Kuczora
> Assignee: Marta Kuczora
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23410.1.patch
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> This is a follow-up task for
> [HIVE-21164|https://issues.apache.org/jira/browse/HIVE-21164], where the
> insert operation has been modified to write directly to the table locations
> instead of the staging directory. The same improvement should be done for the
> ACID update and delete operations as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
