[
https://issues.apache.org/jira/browse/HIVE-24332?focusedWorklogId=524453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524453
]
ASF GitHub Bot logged work on HIVE-24332:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 14:14
Start Date: 15/Dec/20 14:14
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1634:
URL: https://github.com/apache/hive/pull/1634#discussion_r543377449
##########
File path:
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InternalUtil.java
##########
@@ -143,18 +142,16 @@ private static ObjectInspector
getObjectInspector(TypeInfo type) throws IOExcept
//TODO this has to find a better home, it's also hardcoded as default in
hive would be nice
// if the default was decided by the serde
static void initializeOutputSerDe(AbstractSerDe serDe, Configuration conf,
OutputJobInfo jobInfo)
- throws SerDeException {
- SerDeUtils.initializeSerDe(serDe, conf,
- getSerdeProperties(jobInfo.getTableInfo(),
- jobInfo.getOutputSchema()),
- null);
+ throws SerDeException {
+ serDe.initialize(conf, getSerdeProperties(jobInfo.getTableInfo(),
jobInfo.getOutputSchema()), null);
}
static void initializeDeserializer(Deserializer deserializer, Configuration
conf,
HCatTableInfo info, HCatSchema schema) throws
SerDeException {
Properties props = getSerdeProperties(info, schema);
LOG.info("Initializing " + deserializer.getClass().getName() + " with
properties " + props);
- SerDeUtils.initializeSerDe(deserializer, conf, props, null);
+ AbstractSerDe serde = (AbstractSerDe)deserializer;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524453)
Time Spent: 1h 40m (was: 1.5h)
> Make AbstractSerDe Superclass of all Classes
> --------------------------------------------
>
> Key: HIVE-24332
> URL: https://issues.apache.org/jira/browse/HIVE-24332
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Rework how {{AbstractSerDe}}, {{Deserializer}}, and {{Serializer}} classes
> are designed.
> Simplify, and consolidate more functionality into {{AbstractSerDe}}. Remove
> functionality that is not commonly used. Remove deprecated methods that were
> deprecated in 3.x (or maybe even older).
> Make it like Java's {{ByteChannel}} that provides implementations for both
> {{ReadableByteChannel}} and {{WriteableByteChannel}} interfaces.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
