[ 
https://issues.apache.org/jira/browse/HIVE-24519?focusedWorklogId=525009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-525009
 ]

ASF GitHub Bot logged work on HIVE-24519:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Dec/20 13:06
            Start Date: 16/Dec/20 13:06
    Worklog Time Spent: 10m 
      Work Description: kasakrisz commented on a change in pull request #1772:
URL: https://github.com/apache/hive/pull/1772#discussion_r544282613



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java
##########
@@ -69,6 +72,23 @@ public void analyzeInternal(ASTNode root) throws 
SemanticException {
 
     LOG.debug("Rebuilding materialized view " + 
tableName.getNotEmptyDbTable());
     super.analyzeInternal(rewrittenAST);
+
+    try {
+      Table table = db.getTable(tableName.getDb(), tableName.getTable());

Review comment:
       Thanks for highlighting that we have all necessary info before calling 
`super.analyzeInternal()`.
   Creating `HiveOperation.ALTER_MATERIALIZED_VIEW_REBUILD` was necessary to 
get this work but no need to modify the `rootTasks`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 525009)
    Time Spent: 0.5h  (was: 20m)

> Optimize MV: Materialized views should not rebuild when tables are not 
> modified
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-24519
>                 URL: https://issues.apache.org/jira/browse/HIVE-24519
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Materialized views
>            Reporter: Rajesh Balamohan
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> e.g
> {noformat}
> create materialized view c_c_address as 
> select c_customer_sk from customer c, customer_address ca where 
> c_current_addr_sk = ca.ca_address_id;
> ALTER MATERIALIZED VIEW c_c_address REBUILD; <-- This shouldn't trigger 
> rebuild, when source tables are not modified
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to