[
https://issues.apache.org/jira/browse/HIVE-24535?focusedWorklogId=526945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-526945
]
ASF GitHub Bot logged work on HIVE-24535:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/20 20:33
Start Date: 21/Dec/20 20:33
Worklog Time Spent: 10m
Work Description: pvargacl commented on pull request #1779:
URL: https://github.com/apache/hive/pull/1779#issuecomment-749182942
The FileSystem calls are saved because on S3 AcidUtils#getAcidState will do
a recursive listing (getHdfsDirSnapshots), and when it processes a delta
directory, it will store the file list in ParsedDelta, so when
AcidDirectory#getBaseAndDeltaFiles is called later the files are returned
without a second FS call. If we are on HDFS there is no gain, the
getBaseAndDeltaFiles will still do a listing as it did before in
OrcInputFormat.FileGenerator#callInternalmoved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 526945)
Time Spent: 0.5h (was: 20m)
> Cleanup AcidUtils.Directory and remove unnecessary filesystem listings
> ----------------------------------------------------------------------
>
> Key: HIVE-24535
> URL: https://issues.apache.org/jira/browse/HIVE-24535
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> * AcidUtils.getAcidState is doing a recursive listing on S3 FileSystem, it
> already knows the content of each delta and base directory, this could be
> returned to OrcInputFormat, to avoid listing each delta directory again there.
> * AcidUtils.getAcidstate submethods are collecting more and more infos about
> the state of the data directory. This could be done directly to the final
> Directory object to avoid 10+ parameters in methods.
> * AcidUtils.Directory, OrcInputFormat.AcidDirInfo and AcidUtils.TxnBase can
> be merged to one class, to clean up duplications.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
