[
https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=527915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527915
]
ASF GitHub Bot logged work on HIVE-24308:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Dec/20 01:03
Start Date: 24/Dec/20 01:03
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #1604:
URL: https://github.com/apache/hive/pull/1604#issuecomment-750677688
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the [email protected] list if the patch is in
need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 527915)
Time Spent: 50m (was: 40m)
> FIX conditions used for DPHJ conversion
> -----------------------------------------
>
> Key: HIVE-24308
> URL: https://issues.apache.org/jira/browse/HIVE-24308
> Project: Hive
> Issue Type: Bug
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Found a weird scenario when looking at the ConvertJoinMapJoin logic:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198]
> When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is
> lower than expected the code returns a MJ because of the condition above!
> In general, I believe the ShuffleSize check:
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624]
> should be part of the shuffleJoin DPHJ conversion.
> And the preferred conversion would be: MJ > DPHJ > SMB
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
