[
https://issues.apache.org/jira/browse/HIVE-24550?focusedWorklogId=530623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530623
]
ASF GitHub Bot logged work on HIVE-24550:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 12:03
Start Date: 04/Jan/21 12:03
Worklog Time Spent: 10m
Work Description: pvargacl commented on a change in pull request #1795:
URL: https://github.com/apache/hive/pull/1795#discussion_r551277198
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java
##########
@@ -527,11 +527,15 @@ void release() {
release(!hiveLocks.isEmpty());
}
- void destroy() {
+ void destroy(String queryIdFromDriver) {
+ // We need cleanup transactions, even if we did not acquired locks yet
+ // However TxnManager is bound to session, so wee need to check if it is
already handling a new query
Review comment:
If txnManager is handling a new query, the previous one must be either
committed or aborted otherwise the second query's openTxn call would have
failed with an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530623)
Time Spent: 40m (was: 0.5h)
> Cleanup only transaction information for the current DriverContext
> ------------------------------------------------------------------
>
> Key: HIVE-24550
> URL: https://issues.apache.org/jira/browse/HIVE-24550
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Affects Versions: 4.0.0
> Reporter: John Sherman
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Long term solution would be: https://issues.apache.org/jira/browse/HIVE-24549
> Short term solution for the common usage pattern described in HIVE-24549 is
> to ensure the current driverContext queryId matches the TxnManagers queryId.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
