[
https://issues.apache.org/jira/browse/HIVE-24541?focusedWorklogId=530675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530675
]
ASF GitHub Bot logged work on HIVE-24541:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 13:57
Start Date: 04/Jan/21 13:57
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1797:
URL: https://github.com/apache/hive/pull/1797#discussion_r551331191
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java
##########
@@ -69,6 +69,12 @@ public boolean fillStorageFormat(ASTNode child) throws
SemanticException {
}
break;
case HiveParser.TOK_FILEFORMAT_GENERIC:
+ if (storageHandler != null) {
+ // Under normal circumstances, we should not get here (since STORED BY
and STORED AS are incompatible within the
+ // same command). Only scenario we can end up here is if a default
storage handler class is set in the config.
+ // In this case, we opt to ignore the STORED AS clause.
Review comment:
Maybe log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530675)
Time Spent: 0.5h (was: 20m)
> Add config to set a default storage handler class
> -------------------------------------------------
>
> Key: HIVE-24541
> URL: https://issues.apache.org/jira/browse/HIVE-24541
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add a config param "hive.default.storage.handler.class" so we can set a
> default storage handler class that can be used for all create table
> statements. By default it would be an empty string, taking no effect.
> This would allow existing user queries to be reused for a new table format
> for example, such as Iceberg.
> For example, after setting in the config: hive.default.storage.handler.class=
> org.apache.iceberg.mr.hive.HiveIcebergStorageHandler
> The query: CREATE TABLE abc (a int, b string) LOCATION ...
> would be equivalent to: CREATE TABLE abc (a int, b string) STORED BY
> 'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler' LOCATION ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
