[
https://issues.apache.org/jira/browse/HIVE-24607?focusedWorklogId=533753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533753
]
ASF GitHub Bot logged work on HIVE-24607:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/21 04:15
Start Date: 10/Jan/21 04:15
Worklog Time Spent: 10m
Work Description: zabetak commented on pull request #1843:
URL: https://github.com/apache/hive/pull/1843#issuecomment-757383120
> How are you planning to use this annotation? I mean are there going to be
tests which will be skipped if the ports are not available? That would mean
that patches that are breaking some tests may be merged in the event the test
that is broken is just skipped due to the used port!
Hey @miklosgergely, thanks for taking a look. In my mind, I wanted to avoid
things that fail locally on local dev environment cause people have things
bounded on different ports all the time.
After some thinking though, I agree with you that skipping tests under these
conditions may not be a good idea since it might hide some more serious
problems. For the particular use-case where I was planning to use the
annotation I found an alternative approach that I like more thus I am closing
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 533753)
Time Spent: 1h (was: 50m)
> Add JUnit annotation for running tests only if ports are available
> ------------------------------------------------------------------
>
> Key: HIVE-24607
> URL: https://issues.apache.org/jira/browse/HIVE-24607
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Some unit tests tend to rely on some specific ports assuming that they are
> available. Moreover, in some cases it is necessary to create explicitly a
> socket bound to some specific port.
> The goal of this Jira is to add a JUnit annotation that will run a test only
> if the requested ports are available (skip it otherwise).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
