[
https://issues.apache.org/jira/browse/HIVE-24617?focusedWorklogId=534430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534430
]
ASF GitHub Bot logged work on HIVE-24617:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/21 18:50
Start Date: 11/Jan/21 18:50
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1853:
URL: https://github.com/apache/hive/pull/1853#discussion_r555265817
##########
File path: beeline/src/java/org/apache/hive/beeline/BeeLine.java
##########
@@ -2298,23 +2293,17 @@ public void addLocalDriverClazz(String driverClazz) {
supportedLocalDriver.add(driverClazz);
}
- Driver[] scanDrivers(String line) throws IOException {
- return scanDrivers(false);
- }
-
- Driver[] scanDrivers(boolean knownOnly) throws IOException {
Review comment:
This `knownOnly` flag is never used, so remove it. By extension, the
`scanDrivers(String line)` is also defunct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 534430)
Time Spent: 20m (was: 10m)
> Review beeline Driver Scanning Code
> -----------------------------------
>
> Key: HIVE-24617
> URL: https://issues.apache.org/jira/browse/HIVE-24617
> Project: Hive
> Issue Type: Improvement
> Components: Beeline
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There seems to be quite a few code artifacts laying around the area of the
> code that are no longer valid. Remove and improve.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
