[
https://issues.apache.org/jira/browse/HIVE-24543?focusedWorklogId=534652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534652
]
ASF GitHub Bot logged work on HIVE-24543:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/21 03:35
Start Date: 12/Jan/21 03:35
Worklog Time Spent: 10m
Work Description: vihangk1 commented on a change in pull request #1791:
URL: https://github.com/apache/hive/pull/1791#discussion_r555489284
##########
File path:
service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java
##########
@@ -76,6 +77,9 @@ public static PasswdAuthenticationProvider
getAuthenticationProvider(AuthMethods
return new CustomAuthenticationProviderImpl((conf == null) ?
AuthMethods.CUSTOM.getConf() : conf);
} else if (authMethod == AuthMethods.NONE) {
return new AnonymousAuthenticationProviderImpl();
+ } else if (authMethod == AuthMethods.SAML) {
+ //TODO right thing to do?
+ return new AnonymousAuthenticationProviderImpl();
Review comment:
I don't think it is necessary. I removed this from the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 534652)
Time Spent: 4h 50m (was: 4h 40m)
> Support SAML 2.0 as an authentication mechanism
> -----------------------------------------------
>
> Key: HIVE-24543
> URL: https://issues.apache.org/jira/browse/HIVE-24543
> Project: Hive
> Issue Type: New Feature
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> With cloud based deployments, having a SAML 2.0 based authentication support
> in HS2 will be greatly useful in case of federated or external identity
> providers like Okta, PingIdentity or Azure AD.
> This authentication mechanism can initially be only supported on http
> transport mode in HiveServer2 since the SAML 2.0 protocol is primarily
> designed for web clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
