[
https://issues.apache.org/jira/browse/HIVE-24558?focusedWorklogId=535195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535195
]
ASF GitHub Bot logged work on HIVE-24558:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/21 04:26
Start Date: 13/Jan/21 04:26
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1804:
URL: https://github.com/apache/hive/pull/1804#discussion_r556254819
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -968,6 +979,9 @@ private boolean shouldResumePreviousDump(Path lastDumpPath,
boolean isBootStrap)
return false;
}
Path hiveDumpPath = new Path(lastDumpPath, ReplUtils.REPL_HIVE_BASE_DIR);
+ if (tableExpressionModified(new DumpMetaData(hiveDumpPath, conf))) {
Review comment:
We can reuse the same DumpMetaData object in the below check also,
would avoid FileSystem read call:
if (isBootStrap) {
return shouldResumePreviousDump(new DumpMetaData(hiveDumpPath, conf));
}
Second thing, I was also wondering if isBootStrap is true , do we even need
that check or we can simply return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 535195)
Time Spent: 0.5h (was: 20m)
> Handle update in table level regular expression.
> ------------------------------------------------
>
> Key: HIVE-24558
> URL: https://issues.apache.org/jira/browse/HIVE-24558
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24558.01.patch, HIVE-24558.02.patch,
> HIVE-24558.03.patch, HIVE-24558.04.patch, HIVE-24558.05.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
