[
https://issues.apache.org/jira/browse/HIVE-24673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270404#comment-17270404
]
Mustafa İman commented on HIVE-24673:
-------------------------------------
[~zabetak] I think the only difference is that negative drivers assert non-zero
return value from tests. If we use the same driver for negative and positive
tests, then we need to hint the expected return code to the driver somehow. If
we keep the same directory structure, it is easy. Tests in
clientnegative/negative directory expect a non-zero while the others expect
zero exit code.
I think it makes sense to merge the drivers. The bulk of this ticket is to take
care of all the changing exceptions in .out files because of migration toz from
MapReduce to Tez. After that is taken care of, I think we can do a followup for
merge.
> Migrate NegativeCliDriver and NegativeMinimrCliDriver to llap
> -------------------------------------------------------------
>
> Key: HIVE-24673
> URL: https://issues.apache.org/jira/browse/HIVE-24673
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> These test drivers should run on llap. Otherwise we can run into situations
> where certain queries correctly fail on MapReduce but not on Tez.
> Also, it is better if negative cli drivers does not mask "Caused by" lines in
> test output. Otherwise, a query may start to fail for other reasons than the
> expected one and we do not realize it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
