[
https://issues.apache.org/jira/browse/HIVE-24681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271270#comment-17271270
]
Zoltan Haindrich commented on HIVE-24681:
-----------------------------------------
I think this would most likely need some kind of dsl to be placed in the q
files instead of just a set of queries - we always had some level of dsl
elements there (to execute dfs commands) ; and lately there are a few simple
qoptions as well.
I would like to note that placing more stuff into a single qfile can be counter
productive: I had to debug some of them in the past ; and it's really hard to
work with them.
I've made some notes about similar things a few years ago; some of it might be
entirely outdated - some of that have become a reality in some way; it might
contain some ideas - so I just leave a link to it right
[here|https://docs.google.com/document/d/1KtcIx8ggL9LxDintFuJo8NQuvNWkmtvv_ekbWrTLNGc/edit]
:)
> Run positive/negative qtests with the same CLI drivers
> ------------------------------------------------------
>
> Key: HIVE-24681
> URL: https://issues.apache.org/jira/browse/HIVE-24681
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Stamatis Zampetakis
> Priority: Minor
>
> Currently tests that should fail need to run with some variant of
> {{NegativeCliDriver}} which expects that the return code for a query is
> non-zero. Alternatively, we could include the error (if any) in the query
> output file itself and assert simply that the output didn't change. There are
> certain advantages in doing so:
> * Simpler code and less classes to maintain;
> * Possibility to mix positive/negative queries in the same .q file;
> * Possibility to include multiple negative queries in the same .q file;
> * No need for special directory structure for positive/negative tests;
> The proposal above implies removing {{NegativeCliDriver}} and related code in
> favor of the regular CLI drivers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
