[
https://issues.apache.org/jira/browse/HIVE-24691?focusedWorklogId=542861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542861
]
ASF GitHub Bot logged work on HIVE-24691:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 14:25
Start Date: 27/Jan/21 14:25
Worklog Time Spent: 10m
Work Description: zmatyus commented on a change in pull request #1916:
URL: https://github.com/apache/hive/pull/1916#discussion_r565348608
##########
File path: pom.xml
##########
@@ -1360,6 +1360,13 @@
</bannedImports>
<includeTestCode>true</includeTestCode>
</restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.RestrictImports">
+ <reason>Do not use commons-logging; use slf4j</reason>
+ <bannedImports>
+ <bannedImport>org.apache.commons.logging.**</bannedImport>
Review comment:
I'm not sure. We have 4 imports altogether; but these were present in
HIVE-20019 too.
```
accumulo-handler/src/java/.../accumulo/mr/HiveAccumuloTableInputFormat.java:import
org.apache.log4j.Level;
accumulo-handler/src/test/.../accumulo/TestHiveAccumuloHelper.java:import
org.apache.log4j.Logger;
llap-server/src/java/.../llap/daemon/impl/ContainerRunnerImpl.java:import
org.apache.log4j.NDC;
llap-server/src/java/.../llap/daemon/impl/TaskRunnerCallable.java:import
org.apache.log4j.NDC;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542861)
Time Spent: 0.5h (was: 20m)
> Ban commons-logging (again)
> ---------------------------
>
> Key: HIVE-24691
> URL: https://issues.apache.org/jira/browse/HIVE-24691
> Project: Hive
> Issue Type: Bug
> Components: Logging
> Affects Versions: 4.0.0
> Reporter: Zoltan Matyus
> Assignee: Zoltan Matyus
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The usage of commons-logging has been completely removed once from Hive in
> HIVE-20019. However, new usage has been added since, despite attempts to ban
> this (bannedDependencies). I'm removing all usage again, and add another way
> to ban using it (restrictImports).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
