[
https://issues.apache.org/jira/browse/HIVE-24674?focusedWorklogId=543468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543468
]
ASF GitHub Bot logged work on HIVE-24674:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/21 09:12
Start Date: 28/Jan/21 09:12
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #1897:
URL: https://github.com/apache/hive/pull/1897#discussion_r565930139
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -177,11 +177,6 @@ private void initReplDump(ASTNode ast) throws
HiveException {
for (String dbName : Utils.matchesDb(db, dbNameOrPattern)) {
Database database = db.getDatabase(dbName);
if (database != null) {
- if (!isMetaDataOnly &&
!ReplChangeManager.isSourceOfReplication(database)) {
Review comment:
In case the source is old, it won't allow dump without the conf set, if
it is new, we would add the config, so in all cases the conf would be set, so
we won't need this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543468)
Time Spent: 50m (was: 40m)
> Set repl.source.for property in the db if db is under replication
> -----------------------------------------------------------------
>
> Key: HIVE-24674
> URL: https://issues.apache.org/jira/browse/HIVE-24674
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add repl.source.for property in the database in case not already set, if the
> database is under replication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
