[
https://issues.apache.org/jira/browse/HIVE-24730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278668#comment-17278668
]
Mustafa İman commented on HIVE-24730:
-------------------------------------
Yes, I think we should try to simplify by putting the configs in xml files
first. Overriding xml configs is confusing. Overriding in some cases is more
confusing.
> Shims classes override values from hive-site.xml and tez-site.xml silently
> --------------------------------------------------------------------------
>
> Key: HIVE-24730
> URL: https://issues.apache.org/jira/browse/HIVE-24730
> Project: Hive
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Since HIVE-14887,
> [Hadoop23Shims|https://github.com/apache/hive/blob/master/shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java]
> silently overrides e.g. hive.tez.container.size which is defined in
> data/conf/hive/llap/hive-site.xml. This way, the developer will have no idea
> about what happened after setting those values in the xml.
> My proposal:
> 1. don't set those values, unless they contain the default value (e.g.: -1
> for hive.tez.container.size)
> 2. put an INFO level log message about the override
> OR:
> put a comment in hive-site.xml and tez-site.xml files that shims override it
> while creating a tez mini cluster
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
