[
https://issues.apache.org/jira/browse/HIVE-24416?focusedWorklogId=548554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-548554
]
ASF GitHub Bot logged work on HIVE-24416:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/21 10:33
Start Date: 05/Feb/21 10:33
Worklog Time Spent: 10m
Work Description: abstractdog opened a new pull request #1945:
URL: https://github.com/apache/hive/pull/1945
### What changes were proposed in this pull request?
Addressing a performance optimization in HiveCharWritable::getStrippedValue:
```
- // A lot of these methods could be done more efficiently by operating
on the Text value
- // directly, rather than converting to HiveChar.
- return new Text(getHiveChar().getStrippedValue());
```
### Why are the changes needed?
Performance.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New unit tests are included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 548554)
Time Spent: 20m (was: 10m)
> Optimise HiveCharWritable::getStrippedValue
> -------------------------------------------
>
> Key: HIVE-24416
> URL: https://issues.apache.org/jira/browse/HIVE-24416
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Attachments: Screenshot 2020-11-24 at 10.36.51 AM.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> !Screenshot 2020-11-24 at 10.36.51 AM.png|width=1126,height=404!
>
> Multiple text conversions can be avoided in
> HiveCharWritable::getStrippedValue for removing trailing spaces.
>
> https://github.com/apache/hive/blob/master/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveCharWritable.java#L87
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
