[
https://issues.apache.org/jira/browse/HIVE-24624?focusedWorklogId=550071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550071
]
ASF GitHub Bot logged work on HIVE-24624:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/21 07:08
Start Date: 09/Feb/21 07:08
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1855:
URL: https://github.com/apache/hive/pull/1855#discussion_r572639940
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -318,27 +317,38 @@ private void analyzeReplLoad(ASTNode ast) throws
SemanticException {
.getEncodedDumpRootPath(conf, sourceDbNameOrPattern.toLowerCase()),
conf), conf)) {
throw new
Exception(ErrorMsg.REPL_FAILED_WITH_NON_RECOVERABLE_ERROR.getMsg());
}
- if (loadPath != null) {
- DumpMetaData dmd = new DumpMetaData(loadPath, conf);
-
- boolean evDump = false;
- // we will decide what hdfs locations needs to be copied over here as
well.
- if (dmd.isIncrementalDump()) {
- LOG.debug("{} contains an incremental dump", loadPath);
- evDump = true;
- } else {
- LOG.debug("{} contains an bootstrap dump", loadPath);
- }
- ReplLoadWork replLoadWork = new ReplLoadWork(conf,
loadPath.toString(), sourceDbNameOrPattern,
- replScope.getDbName(),
- dmd.getReplScope(),
- queryState.getLineageState(), evDump, dmd.getEventTo(),
dmd.getDumpExecutionId(),
- initMetricCollection(!evDump, loadPath.toString(),
replScope.getDbName(),
- dmd.getDumpExecutionId()), dmd.isReplScopeModified());
- rootTasks.add(TaskFactory.get(replLoadWork, conf));
- } else {
+
+ if (loadPath == null) {
+ return;
Review comment:
Add a log line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550071)
Time Spent: 1h 10m (was: 1h)
> Repl Load should detect the compatible staging dir
> --------------------------------------------------
>
> Key: HIVE-24624
> URL: https://issues.apache.org/jira/browse/HIVE-24624
> Project: Hive
> Issue Type: Improvement
> Reporter: Pratyushotpal Madhukar
> Assignee: Pratyushotpal Madhukar
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24624.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Repl load in CDP when pointed to a staging dir should be able to detect
> whether the staging dir has the dump structure in compatible format or not
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
