[
https://issues.apache.org/jira/browse/HIVE-24762?focusedWorklogId=550612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550612
]
ASF GitHub Bot logged work on HIVE-24762:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 07:46
Start Date: 10/Feb/21 07:46
Worklog Time Spent: 10m
Work Description: abstractdog opened a new pull request #1965:
URL: https://github.com/apache/hive/pull/1965
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550612)
Remaining Estimate: 0h
Time Spent: 10m
> StringValueBoundaryScanner ignores boundary which leads to incorrect results
> -----------------------------------------------------------------------------
>
> Key: HIVE-24762
> URL: https://issues.apache.org/jira/browse/HIVE-24762
> Project: Hive
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java#L901
> {code}
> public boolean isDistanceGreater(Object v1, Object v2, int amt) {
> ...
> return s1 != null && s2 != null && s1.compareTo(s2) > 0;
> {code}
> Like other boundary scanners, StringValueBoundaryScanner should take amt into
> account, otherwise it'll result in the same range regardless of the given
> window size. This typically affects queries where the range is defined on a
> string column:
> {code}
> select p_mfgr, p_name, p_retailprice,
> count(*) over(partition by p_mfgr order by p_name range between 1 preceding
> and current row) as cs1,
> count(*) over(partition by p_mfgr order by p_name range between 3 preceding
> and current row) as cs2
> from vector_ptf_part_simple_orc;
> {code}
> with "> 0" cs1 and cs2 will be calculated on the same window, so cs1 == cs2,
> but actually it should be different, this is the correct result (see "almond
> antique olive coral navajo"):
> {code}
> +-----------------+---------------------------------------------+------+------+
> | p_mfgr | p_name | cs1 | cs2
> |
> +-----------------+---------------------------------------------+------+------+
> | Manufacturer#1 | almond antique burnished rose metallic | 2 | 2
> |
> | Manufacturer#1 | almond antique burnished rose metallic | 2 | 2
> |
> | Manufacturer#1 | almond antique chartreuse lavender yellow | 6 | 6
> |
> | Manufacturer#1 | almond antique chartreuse lavender yellow | 6 | 6
> |
> | Manufacturer#1 | almond antique chartreuse lavender yellow | 6 | 6
> |
> | Manufacturer#1 | almond antique chartreuse lavender yellow | 6 | 6
> |
> | Manufacturer#1 | almond antique salmon chartreuse burlywood | 1 | 1
> |
> | Manufacturer#1 | almond aquamarine burnished black steel | 1 | 8
> |
> | Manufacturer#1 | almond aquamarine pink moccasin thistle | 4 | 4
> |
> | Manufacturer#1 | almond aquamarine pink moccasin thistle | 4 | 4
> |
> | Manufacturer#1 | almond aquamarine pink moccasin thistle | 4 | 4
> |
> | Manufacturer#1 | almond aquamarine pink moccasin thistle | 4 | 4
> |
> | Manufacturer#2 | almond antique violet chocolate turquoise | 1 | 1
> |
> | Manufacturer#2 | almond antique violet turquoise frosted | 3 | 3
> |
> | Manufacturer#2 | almond antique violet turquoise frosted | 3 | 3
> |
> | Manufacturer#2 | almond antique violet turquoise frosted | 3 | 3
> |
> | Manufacturer#2 | almond aquamarine midnight light salmon | 1 | 5
> |
> | Manufacturer#2 | almond aquamarine rose maroon antique | 2 | 2
> |
> | Manufacturer#2 | almond aquamarine rose maroon antique | 2 | 2
> |
> | Manufacturer#2 | almond aquamarine sandy cyan gainsboro | 3 | 3
> |
> | Manufacturer#3 | almond antique chartreuse khaki white | 1 | 1
> |
> | Manufacturer#3 | almond antique forest lavender goldenrod | 4 | 5
> |
> | Manufacturer#3 | almond antique forest lavender goldenrod | 4 | 5
> |
> | Manufacturer#3 | almond antique forest lavender goldenrod | 4 | 5
> |
> | Manufacturer#3 | almond antique forest lavender goldenrod | 4 | 5
> |
> | Manufacturer#3 | almond antique metallic orange dim | 1 | 1
> |
> | Manufacturer#3 | almond antique misty red olive | 1 | 1
> |
> | Manufacturer#3 | almond antique olive coral navajo | 1 | 3
> |
> | Manufacturer#4 | almond antique gainsboro frosted violet | 1 | 1
> |
> | Manufacturer#4 | almond antique violet mint lemon | 1 | 1
> |
> | Manufacturer#4 | almond aquamarine floral ivory bisque | 2 | 4
> |
> | Manufacturer#4 | almond aquamarine floral ivory bisque | 2 | 4
> |
> | Manufacturer#4 | almond aquamarine yellow dodger mint | 1 | 1
> |
> | Manufacturer#4 | almond azure aquamarine papaya violet | 1 | 1
> |
> | Manufacturer#5 | almond antique blue firebrick mint | 1 | 1
> |
> | Manufacturer#5 | almond antique medium spring khaki | 2 | 2
> |
> | Manufacturer#5 | almond antique medium spring khaki | 2 | 2
> |
> | Manufacturer#5 | almond antique sky peru orange | 1 | 1
> |
> | Manufacturer#5 | almond aquamarine dodger light gainsboro | 1 | 5
> |
> | Manufacturer#5 | almond azure blanched chiffon midnight | 1 | 1
> |
> +-----------------+---------------------------------------------+------+------+
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
