[
https://issues.apache.org/jira/browse/HIVE-24739?focusedWorklogId=552985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552985
]
ASF GitHub Bot logged work on HIVE-24739:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/21 14:16
Start Date: 16/Feb/21 14:16
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1946:
URL: https://github.com/apache/hive/pull/1946#discussion_r576854867
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java
##########
@@ -113,43 +113,68 @@ protected void initServer() {
// TCP Server
server = new TThreadPoolServer(sargs);
server.setServerEventHandler(new TServerEventHandler() {
+
@Override
public ServerContext createContext(TProtocol input, TProtocol output) {
Metrics metrics = MetricsFactory.getInstance();
if (metrics != null) {
- try {
Review comment:
@pvary Thanks for the review!
I removed this because there is another place in this same class that does
not wrap the calls in a `try` block so I am trying to keep in consistent, but
also, the method `incrementCounter` does not throw anything.
https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java#L71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 552985)
Time Spent: 4h 20m (was: 4h 10m)
> Clarify Usage of Thrift TServerEventHandler and Count Number of Messages
> Processed
> ----------------------------------------------------------------------------------
>
> Key: HIVE-24739
> URL: https://issues.apache.org/jira/browse/HIVE-24739
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Make the messages emitted from {{TServerEventHandler}} more meaningful.
> Also, track the number of messages that each client sends to aid in
> troubleshooting.
> I run into this issue all the time with and this would greatly help clarify
> the logging.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
