[
https://issues.apache.org/jira/browse/HIVE-24738?focusedWorklogId=556373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556373
]
ASF GitHub Bot logged work on HIVE-24738:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 15:03
Start Date: 23/Feb/21 15:03
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1971:
URL: https://github.com/apache/hive/pull/1971#discussion_r581112577
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -4521,7 +4523,9 @@ public static void handleDirectInsertTableFinalPath(Path
specPath, String unionS
for (int i = 0; i < partitionCount; ++i) {
String nextPart = mdis.readUTF();
Utilities.FILE_OP_LOGGER.debug("Looking at dynamic partition {}",
nextPart);
- dynamicPartitionSpecs.add(nextPart);
+ if (!dynamicPartitionSpecs.containsKey(nextPart)) {
+ dynamicPartitionSpecs.put(nextPart, new ArrayList<>());
Review comment:
What is the expected order of the items in the list?
Do we really need a list there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556373)
Time Spent: 2h 40m (was: 2.5h)
> Reuse committed filelist from directInsert manifest during loadPartition
> ------------------------------------------------------------------------
>
> Key: HIVE-24738
> URL: https://issues.apache.org/jira/browse/HIVE-24738
> Project: Hive
> Issue Type: Sub-task
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> This way the costly FileSystem listing can be avoided
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
