[
https://issues.apache.org/jira/browse/HIVE-24739?focusedWorklogId=556488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556488
]
ASF GitHub Bot logged work on HIVE-24739:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 18:00
Start Date: 23/Feb/21 18:00
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1946:
URL: https://github.com/apache/hive/pull/1946#discussion_r581262921
##########
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -147,15 +151,81 @@
protected ThreadLocal<ServerContext> currentServerContext;
+ /**
+ * A context container for information related to client connections to the
+ * Thrift server.
+ */
static class ThriftCLIServerContext implements ServerContext {
- private SessionHandle sessionHandle = null;
- public void setSessionHandle(SessionHandle sessionHandle) {
- this.sessionHandle = sessionHandle;
+ private final long createTime;
+ private final Collection<SessionHandle> hiveSessionHandles;
Review comment:
Here is the relevant code... it does not look like there are any error
conditions barring a user from calling `openSession` multiple times on the same
connection. It just creates a new session and binds it to the connection.
https://github.com/apache/hive/blob/5ab73120605076c1afc65951bcca06045f532683/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java#L337-L341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 556488)
Time Spent: 6h 40m (was: 6.5h)
> Clarify Usage of Thrift TServerEventHandler and Count Number of Messages
> Processed
> ----------------------------------------------------------------------------------
>
> Key: HIVE-24739
> URL: https://issues.apache.org/jira/browse/HIVE-24739
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Make the messages emitted from {{TServerEventHandler}} more meaningful.
> Also, track the number of messages that each client sends to aid in
> troubleshooting.
> I run into this issue all the time with and this would greatly help clarify
> the logging.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
