[
https://issues.apache.org/jira/browse/HIVE-24792?focusedWorklogId=558859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558859
]
ASF GitHub Bot logged work on HIVE-24792:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/21 05:32
Start Date: 27/Feb/21 05:32
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1992:
URL: https://github.com/apache/hive/pull/1992#discussion_r584043504
##########
File path: service/src/java/org/apache/hive/service/cli/operation/Operation.java
##########
@@ -326,6 +326,7 @@ protected synchronized void cleanupOperationLog(final long
operationLogCleanupDe
if (operationLogCleanupDelayMs > 0) {
scheduledExecutorService.schedule(new
OperationLogCleaner(operationLog), operationLogCleanupDelayMs,
TimeUnit.MILLISECONDS);
+ scheduledExecutorService.shutdown();
Review comment:
If I understand correctly, then the pool is created regardless of the
config. We might want to close outside of the conditional expressions. What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558859)
Time Spent: 50m (was: 40m)
> Potential thread leak in Operation
> ----------------------------------
>
> Key: HIVE-24792
> URL: https://issues.apache.org/jira/browse/HIVE-24792
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The _scheduledExecutorService_ in _Operation_ does not shut down after
> scheduling delay operationlog cleanup, which may result to thread leak in
> hiveserver2...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
