[
https://issues.apache.org/jira/browse/HIVE-24730?focusedWorklogId=559500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559500
]
ASF GitHub Bot logged work on HIVE-24730:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/21 17:35
Start Date: 01/Mar/21 17:35
Worklog Time Spent: 10m
Work Description: abstractdog edited a comment on pull request #1941:
URL: https://github.com/apache/hive/pull/1941#issuecomment-788132782
> @abstractdog I still stand with what I wrote on the Jira. I do not
understand why we have `overrideIntIfDefaultIsSet(conf, x, y, z);` in the code
instead of putting `x=z` in hive-site.xml/tez-site.xml. We do not need any of
this override logic. Why don't we just remove all the overriding madness and
put the correct values in xml files? What am I missing?
okay, I agree, honestly, I created the optional override logic because I
assumed that these mini clusters are used somewhere else where someone relies
on the fact that mini clusters can ensure proper settings
(hive.tez.container.size != -1)...but if so, the above points you mentioned
apply to those as well, so they should take care of the proper settings in XMLs
or whatever before invoking minicluster initialization
I'm about to refresh the patch by completely removing override logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 559500)
Time Spent: 2h 20m (was: 2h 10m)
> Shims classes override values from hive-site.xml and tez-site.xml silently
> --------------------------------------------------------------------------
>
> Key: HIVE-24730
> URL: https://issues.apache.org/jira/browse/HIVE-24730
> Project: Hive
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Since HIVE-14887,
> [Hadoop23Shims|https://github.com/apache/hive/blob/master/shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java]
> silently overrides e.g. hive.tez.container.size which is defined in
> data/conf/hive/llap/hive-site.xml. This way, the developer will have no idea
> about what happened after setting those values in the xml.
> My proposal:
> 1. don't set those values, unless they contain the default value (e.g.: -1
> for hive.tez.container.size)
> 2. put an INFO level log message about the override
> OR:
> put a comment in hive-site.xml and tez-site.xml files that shims override it
> while creating a tez mini cluster
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
