[
https://issues.apache.org/jira/browse/HIVE-24851?focusedWorklogId=562189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562189
]
ASF GitHub Bot logged work on HIVE-24851:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/21 08:34
Start Date: 08/Mar/21 08:34
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2040:
URL: https://github.com/apache/hive/pull/2040#discussion_r589247520
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java
##########
@@ -88,22 +88,39 @@ public AvroGenericRecordReader(JobConf job, FileSplit
split, Reporter reporter)
gdr.setExpected(latest);
}
- if (split.getLength() == 0) {
- this.isEmptyInput = true;
- this.start = 0;
- this.reader = null;
+ org.apache.avro.file.FileReader<GenericRecord> nonFinalReader = null;
+ try {
+ if (split.getLength() == 0) {
+ this.isEmptyInput = true;
+ this.start = 0;
+ this.reader = null;
+ }
+ else {
+ this.isEmptyInput = false;
+ nonFinalReader = new DataFileReader<GenericRecord>(new
FsInput(split.getPath(), job), gdr);
+ this.reader = nonFinalReader;
+ this.reader.sync(split.getStart());
+ this.start = reader.tell();
+ }
+ this.stop = split.getStart() + split.getLength();
+ this.recordReaderID = new UID();
+
+ this.writerTimezone = extractWriterTimezoneFromMetadata(job, split, gdr);
+ this.writerProleptic = extractWriterProlepticFromMetadata(job, split,
gdr);
}
- else {
- this.isEmptyInput = false;
- this.reader = new DataFileReader<GenericRecord>(new
FsInput(split.getPath(), job), gdr);
- this.reader.sync(split.getStart());
- this.start = reader.tell();
+ catch (Exception e) {
+ if (nonFinalReader != null) {
+ try {
+ nonFinalReader.close();
+ }
+ catch (Exception closeException) {
+ if (closeException != e) {
+ e.addSuppressed(closeException);
+ }
+ }
+ }
+ throw e;
Review comment:
Why not close the reader in finally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 562189)
Time Spent: 50m (was: 40m)
> resources leak on exception in AvroGenericRecordReader constructor
> ------------------------------------------------------------------
>
> Key: HIVE-24851
> URL: https://issues.apache.org/jira/browse/HIVE-24851
> Project: Hive
> Issue Type: Bug
> Affects Versions: 3.1.2, 4.0.0
> Reporter: Lukasz Osipiuk
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> AvroGenericRecordReader constructor creates an instance of FileReader but
> lacks proper exception handling, and reader is not closed on the failure path.
> This results in leaking of underlying resources (e.g. S3 connections).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
