[ 
https://issues.apache.org/jira/browse/HIVE-24860?focusedWorklogId=562988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562988
 ]

ASF GitHub Bot logged work on HIVE-24860:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Mar/21 10:36
            Start Date: 09/Mar/21 10:36
    Worklog Time Spent: 10m 
      Work Description: pvary commented on pull request #2052:
URL: https://github.com/apache/hive/pull/2052#issuecomment-793690150


   > I don't think we should allow to change this config at session level. Idea 
was to have a single threadpool for txn heartbeating job. Btw initialization is 
also under the static method.
   
   Yeah, `DbTxnManager.initHeartbeatExecutorService()` is static-like - would 
it hurt to create the ExecutorService in a static block - using the global 
config, and use this service everywhere?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 562988)
    Time Spent: 1h  (was: 50m)

> Shut down DbTxnManager heartbeatExecutorService at session close
> ----------------------------------------------------------------
>
>                 Key: HIVE-24860
>                 URL: https://issues.apache.org/jira/browse/HIVE-24860
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> If the HeartBeaterExecutorService isn't shut down, UDF classes belonging to 
> the session's UDFClassLoader (which was the session thread's context 
> classloader at HeartBeaterExecutorService creation) could pile up and cause 
> Metaspace OOM.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to