[
https://issues.apache.org/jira/browse/HIVE-24881?focusedWorklogId=566776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566776
]
ASF GitHub Bot logged work on HIVE-24881:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/21 08:37
Start Date: 16/Mar/21 08:37
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2068:
URL: https://github.com/apache/hive/pull/2068#discussion_r594958435
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager.java
##########
@@ -459,11 +476,11 @@ public void testHeartbeater() throws Exception {
// Case 3: If there's delay for the heartbeat, and the delay is long
enough to trigger the reaper,
// then the txn will time out and be aborted.
// Here we just don't send the heartbeat at all - an infinite
delay.
- // Start the heartbeat after a delay, which exceeds the HIVE_TXN_TIMEOUT
- ((DbTxnManager) txnMgr).openTxn(ctx, "jerry", TxnType.DEFAULT,
- HiveConf.getTimeVar(conf, HiveConf.ConfVars.HIVE_TXN_TIMEOUT,
TimeUnit.MILLISECONDS) * 2);
+ // Start the heartbeat after a delay, which exceeds the timeout threshold
(e.g. TXN_TIMEOUT)
+ ((DbTxnManager) txnMgr).openTxn(ctx, "jerry", txnType,
+ MetastoreConf.getTimeVar(conf, timeThresholdConfVar,
TimeUnit.MILLISECONDS) * 2);
txnMgr.acquireLocks(qp, ctx, "jerry");
- Thread.sleep(HiveConf.getTimeVar(conf, HiveConf.ConfVars.HIVE_TXN_TIMEOUT,
TimeUnit.MILLISECONDS));
+ Thread.sleep(MetastoreConf.getTimeVar(conf, timeThresholdConfVar,
TimeUnit.MILLISECONDS));
Review comment:
derp :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 566776)
Time Spent: 50m (was: 40m)
> Abort old open replication txns
> -------------------------------
>
> Key: HIVE-24881
> URL: https://issues.apache.org/jira/browse/HIVE-24881
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We should auto-abort/remove open replication txns that are older than a time
> threshold (default: 24h).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
